Remove -dynamiclib flag

theopolisme · theopolisme · commit fea01d8729a1 · 2014-04-17T13:40:37.000-07:00
Introduced in nikhilm#37 as a cosmetic improvement for some specific systems, the dynamiclib flag results in the following error on Mac OS 10.9.2: clang: error: invalid argument '-bundle' not allowed with '-dynamiclib' Removing it resolves the error.
diff --git a/binding.gyp b/binding.gyp
@@ -11,9 +11,6 @@
           'xcode_settings': {
             'OTHER_CFLAGS': [
               '<!@(taglib-config --cflags)'
-            ],
-            'OTHER_LDFLAGS': [
-              '-dynamiclib'
             ]
           }
         }, {

Original file line number	Diff line number	Diff line change
`@@ -11,9 +11,6 @@`
`11`	`11`	`'xcode_settings': {`
`12`	`12`	`'OTHER_CFLAGS': [`
`13`	`13`	`'<!@(taglib-config --cflags)'`
`14`		`- ],`
`15`		`- 'OTHER_LDFLAGS': [`
`16`		`- '-dynamiclib'`
`17`	`14`	`]`
`18`	`15`	`}`
`19`	`16`	`}, {`