Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance Variable Management in Hurl.nvim #220

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Enhance Variable Management in Hurl.nvim #220

wants to merge 2 commits into from
+190 −39

Conversation

sweep-ai[bot]
Copy link
Contributor

@sweep-ai sweep-ai bot commented Jan 14, 2025 •
edited
Loading

Purpose

Improve variable management capabilities in Hurl.nvim by introducing persistent variable storage, env file parsing, and a more robust variable management interface.

This pull request was created to solve the following GitHub issue:

the :HurlManageVariable command doesn't persist values (and doesn't prepopulate from env_file)

Details

No response

Enhance :HurlManageVariable with persistence and env file integration

Description:

The :HurlManageVariable command currently lacks persistence between sessions and doesn't load initial values from the configured env files. This needs to be fixed to improve variable management functionality.

Tasks:

  1. In lua/hurl/main.lua:

    • Modify HurlManageVariable command to load variables from env files on initialization
    • Add persistence functionality to save variables between sessions
    • Update variable management popup to reflect both env file and persisted variables

  2. In lua/hurl/lib/hurl_runner.lua:

    • Add function to parse env files and extract variables
    • Modify variable injection logic to handle both persisted and env file variables

  3. In test/plugin_spec.lua:

    • Add test cases for variable persistence
    • Add test cases for env file variable loading
    • Add test cases for variable management popup

Test:

  • Add the following test cases to test/plugin_spec.lua: 
    it('should load variables from env file', function()
  -- Test env file loading
end)

it('should persist variables between sessions', function()
  -- Test variable persistence
end)

it('should show both env file and persisted variables in popup', function()
  -- Test popup display
end)

Description

This pull request introduces a comprehensive variable management system for Hurl.nvim:

  • Implemented a persistent variable store that can save and load variables between sessions
  • Added support for parsing environment files
  • Enhanced the HurlManageVariable command with new features:
    • Display variables from multiple sources (persisted and env files)
    • Add, edit, and delete variables
    • Persist variables across sessions
    • Show variable source in the management interface

The changes provide users with more flexibility in managing variables for HTTP requests, with improved persistence and visibility.

Summary

  • Added new variable_store.lua library for managing variables
  • Updated main.lua to support advanced variable management
  • Implemented new test cases for variable management
  • Introduced features:
    • Persistent variable storage
    • Environment file parsing
    • Interactive variable management
    • Multi-source variable display

Fixes

Fixes #219. Continue the conversation here: https://app.sweep.dev/c/39d110af-b360-45a7-b1e1-5f2d659ef1be.

To have Sweep make further changes, please add a comment to this PR starting with "Sweep:".

📖 For more information on how to use Sweep, please read our documentation.

Tracking ID: 0927350ecd

@codesandbox CodeSandbox
Copy link

codesandbox bot commented Jan 14, 2025

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 14, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: fabad67

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sweep-ai sweep-ai bot mentioned this pull request Jan 14, 2025
Open
@sweep-ai Sweep AI
Copy link
Contributor Author

sweep-ai bot commented Jan 14, 2025 •
edited
Loading

❌ Error while fixing CI

Traceback 
Traceback (most recent call last):
  File "/app/sweepai/handlers/fix_ci.py", line 285, in fix_ci_failures_once
    logs_list = get_ci_failure_logs(installation_id=installation_id, runs=error_runs, pull_request=pull_request)
  File "/app/sweepai/ci/fetch_ci.py", line 268, in get_ci_failure_logs
    logs = get_ci_failure_log(installation_id, run, pull_request, fetched_urls)
  File "/app/sweepai/ci/fetch_ci.py", line 254, in get_ci_failure_log
    raw_binary_logs = download_raw_logs(
  File "/app/sweepai/ci/fetch_ci.py", line 224, in download_raw_logs
    raise Exception(f"Sweep was unable to fetch CI/CD logs for {repo_full_name} due to GitHub errors.")
Exception: Sweep was unable to fetch CI/CD logs for jellydn/hurl.nvim due to GitHub errors.

Sweep was unable to fetch CI/CD logs for jellydn/hurl.nvim due to GitHub errors.

Sweep has encountered a runtime error unrelated to your request. Please let us know via this link or at [email protected] directly.

📖 For more information on how to use Sweep, please read our documentation.

Tracking ID: 0927350ecd-ci-0

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 14, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Free review on us!

CodeRabbit is offering free reviews until Wed Jan 15 2025 to showcase some of the refinements we've made.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sweep: the :HurlManageVariable command doesn't persist values (and doesn't prepopulate from env_file)
0 participants