Skip to content

App shows "Internet unavailable" message when offline and sending request to domain that resolves to localhost #301

Open
@kaelon141

Description

@kaelon141

When the device is offline / has no internet access, the app still allows sending a request to 127.0.0.1 or localhost. But custom domains mapped to the device are ignored.

I have a development setup where IIS serves as local web server for development, with a custom domain that is mapped to 127.0.0.1 in the device's hosts file. When trying to send a request to this domain without internet access, Nightingale refuses to send the request and shows an "Internet Unavailable" message. When I do have internet, the request is sent.

I think that rather than specifically allowing only 127.0.0.1 and localhost when offline, the app should first attempt to resolve the domain name, and in case the domain can be resolved and points to 127.0.0.1, the request should go through. Only if the device cannot resolve the domain name, or if the domain points to an external IP address, should Nightingale refuse to send the request.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions