Filter by path(ctrl+s) and git log show different output

[antotoki]

I just noticed that when I use Enter path to filter by and select a specific file from the list, there are commits not related just to the selected file but to the folder containing that file. Is intended behaviour?

[stefanhaller]

No, that's not intended. Are you sure that you really selected the file and not the folder containing it? (The feature also supports filtering by folders.)

[antotoki]

As you can see, the selected commit(0f737..) is the one where selected file was created. For some reason, it shows commits from before that, even though it shouldn't.

[stefanhaller]

But wasn't it created by moving it from a different location? The filter feature supports that, and shows you the commits of that previous file in the old location. That's a feature, not a bug.

[antotoki]

But wasn't it created by moving it from a different location?

I can confirm that's not the case. The same issue occurred when I ran git log --follow command so I guess --follow is to blame for this issue.

Is there an option to disable --follow flag when I run Filter by path in Lazygit?

[stefanhaller]

No, there's no way to disable it, since it's almost always desirable (unless it misbehaves for some reason).

Note that --follow relies on git's rename detection heuristics, so on the command line you could try if git log --follow -M100% <path> makes any difference.

We have an option in lazygit to tweak the rename detection threshold (using ( and )), but it only has an affect on the display of diffs, it is not used when filtering. We could consider changing this, but then the question is what happens when you change the threshold while filtering is active; reloading the log in that case would be too expensive.

[antotoki]

It is fine when I use git log --follow -M100% .

But I'd like to have an option to change the threshold value for Filter by option.

[stefanhaller]

It is fine when I use git log --follow -M100% .

Ok, but then I'm confused why the git log --follow seems to have a different idea about what's a rename than the diff. If you select the commit that added the file, the diff should show it as a rename. Or wait, are you using a lazygit version older than 0.54? We fixed the diff for renamed files during filtering in that version.

But I'd like to have an option to change the threshold value for Filter by option.

Like I said, we can use the existing config value for that (git.renameSimilarityThreshold). It can be set globally in the config file, or changed at runtime using ( and ). We just need to use it when filtering, and decide what to do if you change it while filtering is active.