-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
why Chinese cannot be displayed? #2741
Comments
我也有相同的问题,奇怪的是在 WSL2 没有这个问题 |
Same problem. Both windows cmd and WezTerm. |
我这里也是碰到一样的问题了,似乎就是lazygit本身的bug和终端无关, cmd,windows terminal和wezterm都有类似问题. |
😢 +1 |
I have the same problem among wezterm/cmder and windows terminal. None-ASCII font. Font sometimes rendered but soon disappear after moving mouse. The behavior can be found in wez/wezterm#3705 |
I have the same problem on windows terminal and git-bash...powershell have same problem |
I have the same problem |
1 similar comment
I have the same problem |
Version 0.37.0 doesn't have this issue. |
I feel like this issue has been forgotten |
This is not friendly to the Chinese. |
On Linux, I use kitty and it works fine |
It sounds like this issue is specific to windows. Are there other TUIs on windows that correctly render chinese characters? It would be good to find out whether this is an issue on our end or an issue with the terminal |
As a refrence, gitui works fine in windows with windows terminal |
That's good to know. So it's an issue on our end, now we just need to know where the issue comes from. We use tcell to render to the terminal, and it does have a couple open issues relating to rendering chinese characters: |
I have the same problem. If this issue can't be fixed promptly, how can I change the default display language of lazygit in Windows? |
@Penguin-SAMA set the language in your |
@mark2185 After I changed the language key value to 'en', I am unable to run lazygit. |
Just to confirm, the
If it does look like that, could you please clarify what happens when you run |
Sorry, I made a mistake in my previous message. It's working fine now. Thank you for your help. |
@jesseduffield It seems the problems started with |
gdamore/tcell#621 has been resolved. I compiled lazygit using the updated tcell, and now Chinese characters are displayed correctly. |
That's awesome. I'll take care of bumping the tcell dependency. |
Could those of you who reported this problem and who are able to build from source please test if #3352 fixes the issue? Thanks! |
Bump our gocui dependency, which in turn bumps tcell to v2.7.1, which should fix problems with multibyte characters on Windows. Fixes #2741.
@stefanhaller @qrsp I cloned and executed the latest code, and the issue with displaying Chinese characters has been resolved. I am deeply thankful for the contributions of both individuals. |
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
why Chinese cannot be displayed?
Version info:
commit=de69fbd6450178ae64d80180efa64a3bed6489e6, build date=2023-06-22T17:00:41Z, build source=unknown, version=de69fbd6, os=windows, arch=amd64, git version=2.36.1.windows.11
The text was updated successfully, but these errors were encountered: