helm: venafi agent: add volumes and volumeMounts for custom CA bundles

Author: maelvls

deploy/charts/venafi-kubernetes-agent/templates/deployment.yaml

@@ -74,6 +74,9 @@ spec:
             - name: credentials
               mountPath: "/etc/venafi/agent/key"
               readOnly: true
+            {{- with .Values.volumeMounts }}
+            {{- toYaml . | nindent 12 }}
+            {{- end }}
       {{- with .Values.nodeSelector }}
       nodeSelector:
         {{- toYaml . | nindent 8 }}
@@ -95,3 +98,6 @@ spec:
           secret:
             secretName: {{ default "agent-credentials" .Values.authentication.secretName }}
             optional: false
+        {{- with .Values.volumes }}
+        {{- toYaml . | nindent 8 }}
+        {{- end }}

deploy/charts/venafi-kubernetes-agent/tests/deployment_test.yaml

@@ -74,3 +74,27 @@ tests:
       - contains:
           path: spec.template.spec.containers[0].command
           content: notpreflight
+
+  # Check the volumes and volumeMounts works correctly
+  - it: Volumes and VolumeMounts added correctly
+    set:
+      config.organisation: test_org
+      config.cluster: test_cluster
+    values:
+      - ./values/custom-volumes.yaml
+    asserts:
+      - isKind:
+          of: Deployment
+      - equal:
+          # In template this comes after credentials and agent config volumeMounts
+          path: spec.template.spec.containers[0].volumeMounts[?(@.name == "cabundle")]
+          value:
+            mountPath: /etc/ssl/certs/
+            name: cabundle
+            readOnly: true
+      - equal:
+          path: spec.template.spec.volumes[?(@.name == "cabundle")].configmap
+          value:
+            defaultMode: 420
+            name: cabundle
+            optional: true

deploy/charts/venafi-kubernetes-agent/tests/values/custom-volumes.yaml

@@ -0,0 +1,11 @@
+volumes:
+  - name: cabundle
+    configmap:
+      name: cabundle
+      optional: true
+      defaultMode: 0644
+
+volumeMounts:
+  - name: cabundle
+    readOnly: true
+    mountPath: /etc/ssl/certs/

deploy/charts/venafi-kubernetes-agent/values.yaml

@@ -36,7 +36,8 @@ serviceAccount:
 podAnnotations: {}
 
 # -- Optional Pod (all containers) `SecurityContext` options, see https://kubernetes.io/docs/tasks/configure-pod-container/security-context/#set-the-security-context-for-a-pod.
-podSecurityContext: {}
+podSecurityContext:
+  {}
   # runAsUser: 1000
   # runAsGroup: 3000
   # fsGroup: 2000
@@ -60,7 +61,7 @@ podSecurityContext: {}
 securityContext:
   capabilities:
     drop:
-    - ALL
+      - ALL
   readOnlyRootFilesystem: true
   runAsNonRoot: true
   runAsUser: 1000
@@ -90,6 +91,30 @@ command: []
 # For example `["--strict", "--oneshot"]`
 extraArgs: []
 
+# -- Additional volumes to add to the Venafi Kubernetes Agent container. This is
+# useful for mounting a custom CA bundle. For example:
+#
+#     volumes:
+#       - name: cabundle
+#         configmap:
+#           name: cabundle
+#           defaultMode: 0644
+#
+# In order to create the ConfigMap, you can use the following command:
+#
+#     kubectl create configmap cabundle \
+#       --from-file=ca-certificates.crt=/your/custom/ca/bundle
+volumes: []
+
+# -- Additional volume mounts to add to the Venafi Kubernetes Agent container.
+# This is useful for mounting a custom CA bundle. For example:
+#
+#     volumeMounts:
+#       - name: cabundle
+#         readOnly: true
+#         mountPath: /etc/ssl/certs/
+volumeMounts: []
+
 # -- Authentication details for the Venafi Kubernetes Agent
 authentication:
   # -- Name of the secret containing the private key