Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Windows CI #343

Open
Tracked by #173
, #176
...
lishaduck opened this issue Feb 21, 2025 · 2 comments · May be fixed by #344
Open
Tracked by #173
, #176
...

Add Windows CI #343

lishaduck opened this issue Feb 21, 2025 · 2 comments · May be fixed by #344

Comments

@lishaduck
Copy link
Contributor

lishaduck commented Feb 21, 2025 •
edited
Loading

🤦‍♂ See #340.

It'll probably need some normalization, but I'll get it. I don't like breaking my dad :) (or anyone, but especially people I know)

I feel particularly bad because this is the second project migrating to tinyglobby broke, so I should've known better. I thought I had, but clearly not.
@lishaduck lishaduck linked a pull request Feb 21, 2025 that will close this issue
Open
@jfmengels
Copy link
Owner

I don't like breaking my dad

You'll have to explain this idiom to me (unless the author of #340 is your dad...?)

I feel particularly bad because this is the second project migrating to tinyglobby broke

No worries! It's fine if things break temporarily, as long as we fix things afterwords and try to do a good job (which I believe you did). Things will slip through, we can't predict everything (especially on Windows unfortunately...)

@lishaduck
Copy link
Contributor Author

lishaduck commented Feb 21, 2025 •
edited
Loading

unless the author of #340 is your dad...?

Literally my dad :)

No worries! It's fine if things break temporarily, as long as we fix things afterwords and try to do a good job (which I believe you did). Things will slip through, we can't predict everything (especially on Windows unfortunately...)

Yeah, I just thought I'd set up Windows CI when I made that PR, so I wasn't as thorough testing it as I should've been.

Well, at least I finished the major project I'd been working on this afternoon, so I'll freer than I have been for a week or so. I'll go look into normalizing line endings in the test suite.

@jfmengels jfmengels mentioned this issue Feb 21, 2025
Merged
This was referenced Feb 22, 2025
Open
Open
@lishaduck lishaduck moved this from Todo to In Progress in Eli's todo list Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set up CI on Windows lishaduck/node-elm-review
2 participants
@jfmengels @lishaduck