Privatise remaining public test helpers for consistency

Author: joshuay03

test/test_rack_middleware.rb

@@ -8,14 +8,6 @@
 class TestOutputFirefox < Minitest::Test
   include FirefoxTestHelpers
 
-  def build_app(...)
-    Rack::Lint.new(Vernier::Middleware.new(...))
-  end
-
-  def request(opts = {})
-    Rack::MockRequest.env_for("", opts)
-  end
-
   def test_middleware_disabled
     app = lambda { |env| [200, { 'content-type' => 'text/plain' }, ["Hello, World!"]] }
     response = build_app(app).call(request)
@@ -34,4 +26,14 @@ def test_middleware_enabled
     profile_json = Zlib.gunzip(profile_gzip)
     assert_valid_firefox_profile(profile_json)
   end
+
+  private
+
+  def build_app(...)
+    Rack::Lint.new(Vernier::Middleware.new(...))
+  end
+
+  def request(opts = {})
+    Rack::MockRequest.env_for("", opts)
+  end
 end

test/test_time_collector.rb

@@ -3,28 +3,6 @@
 require "test_helper"
 
 class TestTimeCollector < Minitest::Test
-  SLOW_RUNNER = ENV["GITHUB_ACTIONS"] && ENV["RUNNER_OS"] == "macOS"
-  DEFAULT_SLEEP_SCALE =
-      if SLOW_RUNNER
-        1
-      else
-        0.1
-      end
-  SLEEP_SCALE = ENV.fetch("TEST_SLEEP_SCALE", DEFAULT_SLEEP_SCALE).to_f # seconds/100ms
-  SAMPLE_SCALE_INTERVAL = 10_000 * SLEEP_SCALE # Microseconds
-  SAMPLE_SCALE_ALLOCATIONS = 100
-
-  def slow_method
-    sleep SLEEP_SCALE
-  end
-
-  def two_slow_methods
-    slow_method
-    1.times do
-      slow_method
-    end
-  end
-
   def test_receives_gc_events
     collector = Vernier::Collector.new(:wall)
     collector.start
@@ -286,6 +264,29 @@ def test_includes_options_in_result_meta
 
   private
 
+  SLOW_RUNNER = ENV["GITHUB_ACTIONS"] && ENV["RUNNER_OS"] == "macOS"
+  DEFAULT_SLEEP_SCALE =
+      if SLOW_RUNNER
+        1
+      else
+        0.1
+      end
+  SLEEP_SCALE = ENV.fetch("TEST_SLEEP_SCALE", DEFAULT_SLEEP_SCALE).to_f # seconds/100ms
+  SAMPLE_SCALE_INTERVAL = 10_000 * SLEEP_SCALE # Microseconds
+  SAMPLE_SCALE_ALLOCATIONS = 100
+  private_constant :SLOW_RUNNER, :DEFAULT_SLEEP_SCALE, :SLEEP_SCALE, :SAMPLE_SCALE_INTERVAL, :SAMPLE_SCALE_ALLOCATIONS
+
+  def slow_method
+    sleep SLEEP_SCALE
+  end
+
+  def two_slow_methods
+    slow_method
+    1.times do
+      slow_method
+    end
+  end
+
   def assert_similar expected, actual
     delta_ratio =
       if SLOW_RUNNER