Extract into StackTableHelpers

Author: jhawthorn

lib/vernier/parsed_profile.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require "json"
+require_relative "stack_table_helpers"
 
 module Vernier
   class ParsedProfile
@@ -34,6 +35,10 @@ def initialize(thread_data)
 
       attr_reader :strings
 
+      def stack_count = @stack_parents.length
+      def frame_count = @frame_funcs.length
+      def func_count = @func_names.length
+
       def stack_parent_idx(idx) = @stack_parents[idx]
       def stack_frame_idx(idx) = @stack_frames[idx]
 
@@ -45,6 +50,8 @@ def func_filename_idx(idx) = @func_filenames[idx]
       def func_name(idx) = @strings[func_name_idx(idx)]
       def func_filename(idx) = @strings[func_filename_idx(idx)]
       def func_first_lineno(idx) = @func_first_lineno[idx]
+
+      include StackTableHelpers
     end
 
     class Thread

lib/vernier/stack_table.rb

@@ -1,46 +1,7 @@
+require_relative "stack_table_helpers"
+
 module Vernier
   class StackTable
-    def inspect
-      "#<#{self.class.name} #{stack_count} stacks, #{frame_count} frames, #{func_count} funcs>"
-    end
-
-    def to_h
-      {
-        stack_table: {
-          parent: stack_count.times.map { stack_parent_idx(_1) },
-          frame:  stack_count.times.map { stack_frame_idx(_1) }
-        },
-        frame_table: {
-          func: frame_count.times.map { frame_func_idx(_1) },
-          line:  frame_count.times.map { frame_line_no(_1) }
-        },
-        func_table: {
-          name: func_count.times.map { func_name(_1) },
-          filename: func_count.times.map { func_filename(_1) },
-          first_line: func_count.times.map { func_first_lineno(_1) }
-        }
-      }
-    end
-
-    def backtrace(stack_idx)
-      full_stack(stack_idx).map do |stack_idx|
-        frame_idx = stack_frame_idx(stack_idx)
-        func_idx = frame_func_idx(frame_idx)
-        line = frame_line_no(frame_idx)
-        name = func_name(func_idx);
-        filename = func_filename(func_idx);
-
-        "#{filename}:#{line}:in '#{name}'"
-      end
-    end
-
-    def full_stack(stack_idx)
-      full_stack = []
-      while stack_idx
-        full_stack << stack_idx
-        stack_idx = stack_parent_idx(stack_idx)
-      end
-      full_stack
-    end
+    include StackTableHelpers
   end
 end

lib/vernier/stack_table_helpers.rb

@@ -0,0 +1,46 @@
+module Vernier
+  module StackTableHelpers
+    def inspect
+      "#<#{self.class.name} #{stack_count} stacks, #{frame_count} frames, #{func_count} funcs>"
+    end
+
+    def to_h
+      {
+        stack_table: {
+          parent: stack_count.times.map { stack_parent_idx(_1) },
+          frame:  stack_count.times.map { stack_frame_idx(_1) }
+        },
+        frame_table: {
+          func: frame_count.times.map { frame_func_idx(_1) },
+          line:  frame_count.times.map { frame_line_no(_1) }
+        },
+        func_table: {
+          name: func_count.times.map { func_name(_1) },
+          filename: func_count.times.map { func_filename(_1) },
+          first_line: func_count.times.map { func_first_lineno(_1) }
+        }
+      }
+    end
+
+    def backtrace(stack_idx)
+      full_stack(stack_idx).map do |stack_idx|
+        frame_idx = stack_frame_idx(stack_idx)
+        func_idx = frame_func_idx(frame_idx)
+        line = frame_line_no(frame_idx)
+        name = func_name(func_idx);
+        filename = func_filename(func_idx);
+
+        "#{filename}:#{line}:in '#{name}'"
+      end
+    end
+
+    def full_stack(stack_idx)
+      full_stack = []
+      while stack_idx
+        full_stack << stack_idx
+        stack_idx = stack_parent_idx(stack_idx)
+      end
+      full_stack
+    end
+  end
+end

test/test_parsed_profile.rb

@@ -8,5 +8,8 @@ def test_gvl_sleep
     path = File.expand_path("../fixtures/gvl_sleep.vernier.json", __FILE__)
     parsed_profile = Vernier::ParsedProfile.read_file(path)
     main_thread = parsed_profile.main_thread
+
+    stack_table = main_thread.stack_table
+    assert_equal "#<Vernier::ParsedProfile::StackTable 742 stacks, 385 frames, 252 funcs>", stack_table.inspect
   end
 end