Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Each generator should use its own Type instead of BaseApplication #27294

Open
1 task
Tcharl opened this issue Sep 15, 2024 · 1 comment
Open
1 task

Each generator should use its own Type instead of BaseApplication #27294

Tcharl opened this issue Sep 15, 2024 · 1 comment

Comments

@Tcharl
Copy link
Contributor

Tcharl commented Sep 15, 2024

Overview of the issue

With the current implementation, it's difficult to add methods on tasks because they are using BaseApplication as input object.

i.e. { application } passed to asPreparingTaskGroup's method of generator-angular is a BaseApplication instead of the generator-angular/types.d.ts#AngularApplication

Same trick could be implemented for Entity (so that an Angular Entity can contain specific attributes and methods, like angularFormPath

Motivation for or Use Case

It would allow more modularity and ease of extension.

  • Checking this box is mandatory (this is just to show you read everything)
@mshima
Copy link
Member

mshima commented Sep 28, 2024

It’s quite complicated since there is lots of inter dependencies in main generators.
But non application generators types like ci-cd, workspaces needs to be improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants