Skip to content

Commit 67600a7

Browse files
committed
Remove scala-xml and scala-parser-combinators
These modules move to their own repositories: - https://github.com/scala/scala-xml (v1.0-RC3) - https://github.com/scala/scala-parser-combinators (v1.0-RC1) The modularization depends on the new partest, as the old one's classpath handling did not support a modularized scala. The compiler pom now depends on the artifacts published separately, with versions specified in versions.properties. NOTES: - The osgi tests resolve the xml and parsers jars and osgi-fy them, as they are no longer built locally. TODO: Can we move the osgification to the module builds? - Disabled local repositories: don't want to accidentally include unpublished artifacts in releases etc.
1 parent 9c50dd5 commit 67600a7

File tree

118 files changed

+82
-10870
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

118 files changed

+82
-10870
lines changed

build.xml

+68-71
Large diffs are not rendered by default.

dbuild-meta.json

-36
Original file line numberDiff line numberDiff line change
@@ -86,42 +86,6 @@
8686
"name": "scala-actors",
8787
"organization": "org.scala-lang"
8888
},
89-
{
90-
"artifacts": [
91-
{
92-
"extension": "jar",
93-
"name": "scala-xml",
94-
"organization": "org.scala-lang"
95-
}
96-
],
97-
"dependencies": [
98-
{
99-
"extension": "jar",
100-
"name": "scala-library",
101-
"organization": "org.scala-lang"
102-
}
103-
],
104-
"name": "scala-xml",
105-
"organization": "org.scala-lang"
106-
},
107-
{
108-
"artifacts": [
109-
{
110-
"extension": "jar",
111-
"name": "scala-parser-combinators",
112-
"organization": "org.scala-lang"
113-
}
114-
],
115-
"dependencies": [
116-
{
117-
"extension": "jar",
118-
"name": "scala-library",
119-
"organization": "org.scala-lang"
120-
}
121-
],
122-
"name": "scala-parser-combinators",
123-
"organization": "org.scala-lang"
124-
},
12589
{
12690
"artifacts": [
12791
{

src/build/dbuild-meta-json-gen.scala

-6
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,6 @@ val meta =
3333
Project("scala-actors", "org.scala-lang",
3434
Seq(ProjectRef("scala-actors", "org.scala-lang")),
3535
Seq(ProjectRef("scala-library", "org.scala-lang"))),
36-
Project("scala-xml", "org.scala-lang",
37-
Seq(ProjectRef("scala-xml", "org.scala-lang")),
38-
Seq(ProjectRef("scala-library", "org.scala-lang"))),
39-
Project("scala-parser-combinators", "org.scala-lang",
40-
Seq(ProjectRef("scala-parser-combinators", "org.scala-lang")),
41-
Seq(ProjectRef("scala-library", "org.scala-lang"))),
4236

4337
Project("scaladoc", "org.scala-lang",
4438
Seq(ProjectRef("scaladoc", "org.scala-lang")),

src/build/maven/maven-deploy.xml

+3-2
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,9 @@
5555
<copy file="${path}-pom.xml" tofile="${path}-pom-filtered.xml" overwrite="true">
5656
<filterset>
5757
<filter token="VERSION" value="@{version}" />
58+
<filter token="SCALA_BINARY_VERSION" value="${scala.binary.version}" />
59+
<filter token="XML_VERSION" value="${scala-xml.version.number}" />
60+
<filter token="PARSER_COMBINATORS_VERSION" value="${scala-parser-combinators.version.number}" />
5861
<filter token="RELEASE_REPOSITORY" value="${remote.release.repository}" />
5962
<filter token="SNAPSHOT_REPOSITORY" value="${remote.snapshot.repository}" />
6063
<filter token="JLINE_VERSION" value="${jline.version}" />
@@ -108,8 +111,6 @@
108111
<deploy-one name="scala-actors" version="${maven.version.number}" local="@{local}" signed="@{signed}"/>
109112
<deploy-one name="scala-compiler" version="${maven.version.number}" local="@{local}" signed="@{signed}"/>
110113
<deploy-one name="scala-library" version="${maven.version.number}" local="@{local}" signed="@{signed}"/>
111-
<deploy-one name="scala-xml" version="${maven.version.number}" local="@{local}" signed="@{signed}"/>
112-
<deploy-one name="scala-parser-combinators" version="${maven.version.number}" local="@{local}" signed="@{signed}"/>
113114
<deploy-one name="scala-reflect" version="${maven.version.number}" local="@{local}" signed="@{signed}"/>
114115
<deploy-one name="scala-swing" version="${maven.version.number}" local="@{local}" signed="@{signed}"/>
115116
<deploy-one name="scalap" version="${maven.version.number}" local="@{local}" signed="@{signed}"/>

src/build/maven/scala-compiler-pom.xml

+6-6
Original file line numberDiff line numberDiff line change
@@ -38,14 +38,14 @@
3838
<version>@VERSION@</version>
3939
</dependency>
4040
<dependency> <!-- for scaladoc -->
41-
<groupId>org.scala-lang</groupId>
42-
<artifactId>scala-xml</artifactId>
43-
<version>@VERSION@</version>
41+
<groupId>org.scala-lang.modules</groupId>
42+
<artifactId>scala-xml_@SCALA_BINARY_VERSION@</artifactId>
43+
<version>@XML_VERSION@</version>
4444
</dependency>
4545
<dependency> <!-- for scaladoc -->
46-
<groupId>org.scala-lang</groupId>
47-
<artifactId>scala-parser-combinators</artifactId>
48-
<version>@VERSION@</version>
46+
<groupId>org.scala-lang.modules</groupId>
47+
<artifactId>scala-parser-combinators_@SCALA_BINARY_VERSION@</artifactId>
48+
<version>@PARSER_COMBINATORS_VERSION@</version>
4949
</dependency>
5050
<dependency>
5151
<groupId>org.scala-lang</groupId>

src/build/maven/scala-parser-combinators-pom.xml

-59
This file was deleted.

src/build/maven/scala-xml-pom.xml

-59
This file was deleted.

src/build/pack.xml

+4-11
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,12 @@
1010
PROPERTIES
1111
============================================================================ -->
1212

13-
<property file="${basedir}/build.number.maven"/>
1413
<!-- the maven stuff requires version.major, version.minor and version.patch properties.
1514
the "get-scala-revision" script only returns "version.number" -->
15+
<property file="${basedir}/build.number.maven"/>
16+
<!-- also need to know scala binary version and versions for xml and parsers -->
17+
<property file="${basedir}/versions.properties"/>
18+
1619

1720
<!-- ===========================================================================
1821
MAIN DISTRIBUTION PACKAGING
@@ -152,8 +155,6 @@ MAIN DISTRIBUTION PACKAGING
152155
</sequential>
153156
</macrodef>
154157
<mvn-copy-lib mvn.artifact.name="scala-library"/>
155-
<mvn-copy-lib mvn.artifact.name="scala-xml"/>
156-
<mvn-copy-lib mvn.artifact.name="scala-parser-combinators"/>
157158
<mvn-copy-lib mvn.artifact.name="scala-reflect"/>
158159
<mvn-copy-lib mvn.artifact.name="scala-compiler"/>
159160
<mvn-copy-lib mvn.artifact.name="scala-swing"/>
@@ -193,14 +194,6 @@ MAIN DISTRIBUTION PACKAGING
193194
basedir="${build-docs.dir}/library">
194195
<include name="**/*"/>
195196
</jar>
196-
<jar whenmanifestonly="fail" destfile="${dists.dir}/maven/${version.number}/scala-xml/scala-xml-docs.jar"
197-
basedir="${build-docs.dir}/xml">
198-
<include name="**/*"/>
199-
</jar>
200-
<jar whenmanifestonly="fail" destfile="${dists.dir}/maven/${version.number}/scala-parser-combinators/scala-parser-combinators-docs.jar"
201-
basedir="${build-docs.dir}/parser-combinators">
202-
<include name="**/*"/>
203-
</jar>
204197
<jar whenmanifestonly="fail" destfile="${dists.dir}/maven/${version.number}/scala-compiler/scala-compiler-docs.jar"
205198
basedir="${build-docs.dir}/compiler">
206199
<include name="**/*"/>

src/parser-combinators/scala/util/parsing/combinator/ImplicitConversions.scala

-43
This file was deleted.

src/parser-combinators/scala/util/parsing/combinator/JavaTokenParsers.scala

-62
This file was deleted.

0 commit comments

Comments
 (0)