Skip to content

Commit 3b3da6c

Browse files
committed
make kubetest write version to revision instead of job-version as
well
1 parent 8fed8ae commit 3b3da6c

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

kubetest/main.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -545,7 +545,8 @@ func writeMetadata(path, metadataSources string) error {
545545
}
546546

547547
ver := findVersion()
548-
m["job-version"] = ver
548+
m["job-version"] = ver // TODO(krzyzacy): retire
549+
m["revision"] = ver
549550
re := regexp.MustCompile(`^BUILD_METADATA_(.+)$`)
550551
for _, e := range os.Environ() {
551552
p := strings.SplitN(e, "=", 2)

kubetest/main_test.go

+5
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,11 @@ func TestWriteMetadata(t *testing.T) {
4141
key: "job-version",
4242
version: "v1.8.0-alpha.2.251+ba2bdb1aead615",
4343
},
44+
{
45+
sources: nil,
46+
key: "revision",
47+
version: "v1.8.0-alpha.2.251+ba2bdb1aead615",
48+
},
4449
{
4550
sources: map[string]mdata{"images.json": {"imgkey": "imgval"}},
4651
key: "imgkey",

0 commit comments

Comments
 (0)