fix: RET in kele-list-all output works on all resources

Closes #269.

Author: jinnovation

docs/references/changelog.md

@@ -31,6 +31,8 @@ versioning][semver].
 - `kele-proxy-stop`: Interactive completion now filters out contexts without active proxy processes
 - `kele-port-forward` is now inapt if the user does not have permission to create port-forwards
 - `kele-resource-follow-logs` is now inapt if the user does not have permission to get pod logs
+- Fixed a regression where, in `kele-list-mode` buffers created via the `kele-list-all` function,
+  users were unable to `get` a row resource by hitting `RET` on it.
 
 ### Changed
 

kele.el

@@ -1873,13 +1873,14 @@ support that verb will be offered as completion candidates."
 (defvar kele--list-snapshot-time nil
   "The last updated time for a `kele-list-mode' buffer.")
 
-(defvar kele--list-gvk nil
-  "The group-version-kind corresponding to the current `kele-list-mode' buffer.")
-
 (defun kele--list-get-at-point ()
   "`kele-get's the current object at point."
   (let-alist (vtable-current-object)
-    (kele-get kele--list-context .object.metadata.namespace kele--list-gvk .object.metadata.name)))
+    (kele-get
+     kele--list-context
+     .object.metadata.namespace
+     (alist-get 'gvk (oref (magit-section-at) value))
+     .object.metadata.name)))
 
 (defun kele-list-table-dwim ()
   "Run the default action on `kele-list' table entries.
@@ -1913,12 +1914,13 @@ Otherwise, simply `kele-get' the resource at point."
   "Delete the resource at the current line."
   (interactive nil kele-list-mode)
   (let-alist (vtable-current-object)
-    (kele-delete
-     kele--list-context
-     .metadata.namespace
-     (kele--gv-string kele--list-gvk)
-     (oref kele--list-gvk kind)
-     .metadata.name))
+    (let ((gvk (alist-get 'gvk (oref (magit-section-at) value))))
+      (kele-delete
+       kele--list-context
+       .metadata.namespace
+       (kele--gv-string gvk)
+       (oref gvk kind)
+       .metadata.name)))
   (vtable-revert-command))
 
 (defvar kele-list-table-map
@@ -2111,13 +2113,11 @@ See bug#58712.  Remove when Emacs 30 is released."
               ((group version) (kele--groupversion-split gv))
               (gvk (kele--gvk-create :group group :version version :kind kind)))
         (condition-case err
-            (magit-insert-section (kele-list-table)
+            (magit-insert-section (kele-list-table `((gvk . ,gvk)))
               (magit-insert-heading (format "%s: %s"
                                             (propertize "Resources" 'font-lock-face 'magit-section-heading)
                                             (propertize kind 'font-lock-face 'kele-resource-kind-face)))
               (magit-insert-section-body
-                (setq-local kele--list-gvk gvk)
-                (put 'kele--list-gvk 'permanent-local t)
                 (vtable-insert (kele--vtable-tabulate gvk context namespace))
                 (vtable-end-of-table)
                 (insert "\n")))
@@ -2194,19 +2194,15 @@ KIND is not namespaced, returns an error."
                                               group-version
                                               kind)
              (kele--get-namespace-arg :permit-nil t)))))
-  (-let* (((group version) (kele--groupversion-split group-version))
-          (gvk (kele--gvk-create :group group :version version :kind kind))
-          (buf (get-buffer-create (format "*kele: %s/%s [%s(%s)]*"
-                                          group-version
-                                          kind
-                                          context
-                                          (or namespace "<all namespaces>")))))
+  (let ((buf (get-buffer-create (format "*kele: %s/%s [%s(%s)]*"
+                                        group-version
+                                        kind
+                                        context
+                                        (or namespace "<all namespaces>")))))
     (with-current-buffer buf
       (setq-local kele--list-context context)
-      (setq-local kele--list-gvk gvk)
       (setq-local kele--list-snapshot-time (current-time))
       (put 'kele--list-context 'permanent-local t)
-      (put 'kele--list-gvk 'permanent-local t)
       (put 'kele--list-snapshot-time 'permanent-local t)
 
       (let ((inhibit-read-only t))

tests/unit/test-kele.el

@@ -792,25 +792,48 @@ metadata:
   (before-each
     (setq kele-confirm-deletions nil)
     (setq kele--list-context "fake-context")
-    (setq kele--list-gvk (kele--gvk-create
-                          :group "fake-group"
-                          :version "v999"
-                          :kind "fake-kind"))
     (spy-on 'vtable-revert-command)
-    (spy-on 'kele-delete))
+    (spy-on 'kele-delete)
+    (spy-on 'kele-get))
+
+  (describe "`kele--list-get-at-point'"
+    (before-each
+      (let ((fake-gvk (kele--gvk-create :group "fake-group" :version "v999" :kind "fake-kind"))
+            (fake-section (magit-section :type 'kele-list-table)))
+        (oset fake-section value `((gvk . ,fake-gvk)))
+        (spy-on 'vtable-current-object :and-return-value
+                '((object . ((metadata . ((namespace . "fake-namespace")
+                                          (name . "fake-name")))))))
+        (spy-on 'magit-section-at :and-return-value fake-section)))
+
+    (it "retrieves GVK from magit section value"
+      (kele--list-get-at-point)
+      (let ((fake-gvk (kele--gvk-create :group "fake-group" :version "v999" :kind "fake-kind")))
+        (expect 'kele-get :to-have-been-called-with
+                "fake-context"
+                "fake-namespace"
+                fake-gvk
+                "fake-name"))))
+
   (describe "`kele-list-kill'"
     (before-each
-      (spy-on 'vtable-current-object :and-return-value
-              '((metadata . ((namespace . "fake-namespace")
-                             (name . "fake-name"))))))
-    (it "kills the current object"
+      (let ((fake-gvk (kele--gvk-create :group "fake-group" :version "v999" :kind "fake-kind"))
+            (fake-section (magit-section :type 'kele-list-table)))
+        (oset fake-section value `((gvk . ,fake-gvk)))
+        (spy-on 'vtable-current-object :and-return-value
+                '((metadata . ((namespace . "fake-namespace")
+                               (name . "fake-name")))))
+        (spy-on 'magit-section-at :and-return-value fake-section)))
+
+    (it "kills the current object using GVK from magit section"
       (kele-list-kill)
       (expect 'kele-delete :to-have-been-called-with
               "fake-context"
               "fake-namespace"
               "fake-group/v999"
               "fake-kind"
               "fake-name"))
+
     (it "refreshes the table"
       (kele-list-kill)
       (expect 'vtable-revert-command :to-have-been-called))))