Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Flag not working in android sdk #261

Open
OsamaSaqrPaysky opened this issue Dec 6, 2024 · 8 comments
Open

Feature Flag not working in android sdk #261

OsamaSaqrPaysky opened this issue Dec 6, 2024 · 8 comments

Comments

@OsamaSaqrPaysky
Copy link

.setFeatureFlag("settings.enabled", false)
.setConfigOverride("participants.enabled",false)

i try to use the above flags , but not work , i need to hide actions of more / settings and participants buttons .but not working

@saghul
Copy link
Member

saghul commented Dec 6, 2024

What SDK version are you using?

.setConfigOverride("participants.enabled",false)

THis is wrong and should be a flag.

@OsamaSaqrPaysky
Copy link
Author

i use version 10.3.0

@saghul
Copy link
Member

saghul commented Dec 6, 2024

How are you using those flags? Please share the code snippet you are using.

@OsamaSaqrPaysky
Copy link
Author

i create my activity which implement JitsiMeetActivityInterface and in onCreate override method i have this implementation

view = JitsiMeetView(this)
try {
options = JitsiMeetConferenceOptions.Builder()
.setServerURL(URL(url))
.setAudioMuted(true)
.setVideoMuted(true)
.setAudioOnly(false)
.setFeatureFlag("prejoinpage.enabled", false)
.setFeatureFlag("welcomepage.enabled", false)
.setFeatureFlag("requireDisplayName", false)
.setFeatureFlag("overflow-menu.enabled", false)
.setFeatureFlag("participants.enabled", false)
.setFeatureFlag("participants.alwaysVisible", false)
.setFeatureFlag("call-integration.enabled", false) // Disable call integration
.setFeatureFlag("pip.enabled", false) // Disable picture-in-picture
.setFeatureFlag("chat.enabled", false) // Disable chat
.setFeatureFlag("invite.enabled", false) // Disable invite options
.setFeatureFlag("filmstrip.enabled", false)
.setFeatureFlag("audio-only.enabled", false)
.setFeatureFlag("notifications.enabled", false)
.setFeatureFlag("invite.enabled", false) // Disable invite button
.setFeatureFlag("share.enabled", false) // Disable share button
.setFeatureFlag("settings.enabled", false) // Disable settings button
.setFeatureFlag("settings.alwaysVisible", false) // Disable settings button
.setFeatureFlag("toolbox.alwaysVisible", false)
.setFeatureFlag("call-integration.enabled", false) // Disable call integration
.setFeatureFlag("toolbox.enabled", true)
.setRoom("OnlineLifeHospital")
.setUserInfo(userInfo)
.setRoom(url)
.build()
} catch (e: MalformedURLException) {
throw RuntimeException(e)
}
view!!.join(options)
setContentView(view)

@saghul
Copy link
Member

saghul commented Dec 6, 2024

Looks ok. Which flags are not working?

@OsamaSaqrPaysky
Copy link
Author

.setFeatureFlag("settings.alwaysVisible", false) and
.setFeatureFlag("participants.enabled", false)
i want to hide participants and settings buttons .

@saghul
Copy link
Member

saghul commented Dec 7, 2024

@Calinteodor can you PTAL when you get a chance?

@Calinteodor
Copy link
Contributor

Not reproducible with https://github.com/jitsi/jitsi-meet-sdk-samples/tree/master/android/java/JitsiSDKTest.
The correct flags for hiding participants screen and settings screen are:

.setFeatureFlag("participants.enabled", false)
.setFeatureFlag("settings.enabled", false)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants