Why does "jj git push --bookmark foo --allow-new" push the automatically generated bookmark?

[vadimberezniker]

The documentation states:

-b, --bookmark <BOOKMARK> — Push only this bookmark, or bookmarks matching a pattern (can be repeated)

Yet, when I actually run the command it pushes both the named bookmark and the automatically generated one.

[vadimberezniker]

On a related note, if I manually created a bookmark is there a way to have jj skip creating an auto-generated one?

[jennings]

That shouldn't be the case. Can you show the command you're running and its output?

[vadimberezniker]

$ jj new master
Working copy  (@) now at: mmlyytyp 6da7dce3 (empty) (no description set)
Parent commit (@-)      : svktzzuv 8da7eeb4 master | <trimmed>
Added 0 files, modified 5 files, removed 0 files

$ echo "foo" > bar

$ jj commit -m "foo"
Working copy  (@) now at: zqqztsqy 06228497 (empty) (no description set)
Parent commit (@-)      : mmlyytyp 8c9dbb6d foo

$ jj bookmark create test_change -r @-
Created 1 bookmarks pointing to mmlyytyp 8c9dbb6d test_change | foo

$ jj git push -b test_change -c @- --allow-new
Creating bookmark push-mmlyytypvrvu for revision mmlyytypvrvu
Changes to push to origin:
  Add bookmark push-mmlyytypvrvu to 8c9dbb6d0a03
  Add bookmark test_change to 8c9dbb6d0a03
remote: Resolving deltas: 100% (1/1), completed with 1 local object.

[scott2000]

Using the -c @- option tells jj to auto-generate the bookmark name. If you don't want that behavior, you can just not pass that option.

[vadimberezniker]

🤦

Thank you. I cargo-culted -c @- without considering what it was actually doing.
It totally makes sense that -c @- is not needed since I'm giving it a bookmark.
Apologies for the dumb question.

[scott2000]

No worries, it's an easy mistake to make!