Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can the jkcfg/build image use jkcfg/prebuilt? #350

Open
squaremo opened this issue Mar 31, 2020 · 5 comments
Open

Can the jkcfg/build image use jkcfg/prebuilt? #350

squaremo opened this issue Mar 31, 2020 · 5 comments
Assignees

Comments

@squaremo
Copy link
Member

This would speed it up a bit.

@dlespiau
Copy link
Member

dlespiau commented Apr 1, 2020

I originally used the docker image to generate the linux prebuilt binaries as a way to have reproducible builds that don't depend on the developer environment. That said we could have two dockerfiles, one to build things, one using the prebuilt?

@squaremo
Copy link
Member Author

squaremo commented Apr 1, 2020

Ah, so something like,

jkcfg/prebuild -> builds or downloads all binaries etc. for prebuilt
jkcfg/build -> uses prebuilt for jk build

(OK the prebuild v. prebuilt would be confusing, but with different names ...)

@dlespiau
Copy link
Member

dlespiau commented Apr 1, 2020

Yes! That's precisely what I had in mind :)

@squaremo
Copy link
Member Author

squaremo commented Apr 1, 2020

Actually the prebuilt repo could host the prebuild Dockerfile, then the build image could just copy the bits out of the prebuild image. And we should probably use specific digests when we refer to images.

@dlespiau
Copy link
Member

dlespiau commented Apr 1, 2020

Ah yes, even better!

@squaremo squaremo self-assigned this Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants