Java 21 ArrayList getLast is resolved by JavaBeanValueResolver

- fix #1163

Author: jknack

handlebars/src/main/java/com/github/jknack/handlebars/internal/path/DataPath.java

@@ -5,6 +5,9 @@
  */
 package com.github.jknack.handlebars.internal.path;
 
+import java.util.List;
+import java.util.Set;
+
 import com.github.jknack.handlebars.Context;
 import com.github.jknack.handlebars.PathExpression;
 import com.github.jknack.handlebars.ValueResolver;
@@ -18,6 +21,9 @@
  */
 public class DataPath implements PathExpression {
 
+  /** First and last are special in 21. */
+  private static final Set<String> FIXED = Set.of("@last", "@first");
+
   /** Property name. */
   private String name;
 
@@ -40,8 +46,15 @@ public Object eval(
     // with @
     Object value = resolver.resolve(data, name);
     if (value == null) {
-      // without @
-      value = resolver.resolve(data, nameWithoutAtSymbol);
+      if (data instanceof List) {
+        if (!FIXED.contains(name)) {
+          // without @
+          value = resolver.resolve(data, nameWithoutAtSymbol);
+        }
+      } else {
+        // without @
+        value = resolver.resolve(data, nameWithoutAtSymbol);
+      }
     }
     return chain.next(resolver, context, value);
   }

handlebars/src/test/java/com/github/jknack/handlebars/i1163/Issue1163.java

@@ -0,0 +1,23 @@
+/*
+ * Handlebars.java: https://github.com/jknack/handlebars.java
+ * Apache License Version 2.0 http://www.apache.org/licenses/LICENSE-2.0
+ * Copyright (c) 2012 Edgar Espina
+ */
+package com.github.jknack.handlebars.i1163;
+
+import java.awt.*;
+import java.io.IOException;
+import java.util.List;
+
+import org.junit.jupiter.api.Test;
+
+import com.github.jknack.handlebars.AbstractTest;
+
+public class Issue1163 extends AbstractTest {
+
+  @Test
+  public void shouldNotFailOnEmptyList() throws IOException {
+    shouldCompileTo("{{@last}}", List.of(), "");
+    shouldCompileTo("{{@first}}", List.of(), "");
+  }
+}