Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert change to src/util.cpp affected by merge (#958), which removed 'support for -zcashparamsdir parameter' #1862

Open
mattmill30 opened this issue Jun 2, 2021 · 0 comments

Comments

@mattmill30
Copy link

'support for -zcashparamsdir parameter' was committed to src/util.cpp in the miketout/VerusCoin repository by @miketout on Oct 24, 2018 - miketout@8a1e0d0 - and then with his commit 'Integrate latest Zcash fixes and update for non-latin user names' - miketout@99aeab2 - for no apparent reason immediately removed the feature, before creating pull request #958.

This feature has subsequently been added to the upstream zcash repository as 'Allow configure params directory' on Aug 7, 2020 so the feature is clearly not deprecated.
zcash@3b5966e

I think the -zcashparamsdir parameter is more appropriate for separate projects which share the common params with zcash as it distinguishes enhancements and feature sets created by first and third parties, but either way, please reintroduce this parameter either by reverting 99aeab2#diff-449acf764318b0ca96972daf8d28a28af79ad2c3381044851f2953792fcd8eef or merging the upstream -paramsdir parameter - zcash@3b5966e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant