Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading profile from austin>=3.0.0 fails #369

Open
siboehm opened this issue Oct 20, 2021 · 5 comments
Open

Loading profile from austin>=3.0.0 fails #369

siboehm opened this issue Oct 20, 2021 · 5 comments

Comments

@siboehm
Copy link

siboehm commented Oct 20, 2021

To reproduce:

  1. conda install austin==3.1
  2. austin -o outfile.txt python -c "import this"
  3. Upload outfile.txt to Speedscope: "Unrecognized format! See documentation about supported formats."

The issue can be "fixed" by using austin<3.0, or by using the austin>=3.0 combined with austin2speedscope conversion tool. According to @P403n1x87 since https://github.com/jlfwong/speedscope/pull/336/files was merged the new output format of austin>=3.0 should be supported. Is this a bug or expected behaviour? Using austin=2.1.1 with speedscope was always a very seamless experience.

Austin issue for reference: P403n1x87/austin#91

@jlfwong
Copy link
Owner

jlfwong commented Oct 20, 2021

Hi @siboehm, thanks for the report

Ah, I think I may not have deployed/published since that was merged.

If you clone the repo and then run npm install && npm run serve and load the file in the resulting browser tab, does that work?

@siboehm
Copy link
Author

siboehm commented Oct 22, 2021

Sorry, I should've tried that first. It loads without errors if I serve from main. However there is a new issue:

Again I ran austin -o austin_<version>.txt python -c 'import this'.
austin_2_1_1.txt
austin_3_1.txt

Output for austin==3.1:
Screenshot 2021-10-22 at 06-43-16 austin_3_1 txt - speedscope

Output for austin=2.1.1:
Screenshot 2021-10-22 at 06-43-46 austin_2_1 txt - speedscope

austin_3_1.txt last few lines:

P132713;T132713 156
P132713;T132713 156
P132713;T132713 154
P132713;T94566012038032;/home/simon/miniconda3/lib/python3.8/this.py:<module>:28 154

# duration: 32825

@P403n1x87
Copy link
Contributor

P403n1x87 commented Oct 22, 2021

However there is a new issue:

One of the breaking changes between Austin 2 and 3 is the output format, which has been made easier for a machine to parse. Furthermore, the behaviour of the -a option has been switched around, as documented in the changelog. So this is not an issue with Speedscope (but might become a feature request to support the new Austin format).

However, if the "new issue" is the presence of the # duration frame, that could have an easy solution 🙂 .

@siboehm
Copy link
Author

siboehm commented Oct 22, 2021

Oh sorry I should've clarified: The "new issues" was referring to the # duration block that appears at the end. I'm glad the output of -a has switched, this way it's much more readable by default.

@P403n1x87
Copy link
Contributor

I have created #371 to address this new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants