Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import fails with Cannot use "undefined" as a Firestore value if any field is NaN #688

Open
arthabus opened this issue Mar 5, 2021 · 1 comment

Comments

@arthabus
Copy link

arthabus commented Mar 5, 2021

Expected behavior

Import preserves NaN values and completes the import

Actual behavior

If a document contains NaN values, they are translated to "undefined" which makes firebase import fail

Steps to reproduce the behavior

   let profileData = {
        __collections__:{},
        nanField: parseFloat("sfg"),
    }

    const profileRef = firebase.firestore().doc(`users/${uid}`);
    await firestoreImport(profileData, profileRef)
@arthabus
Copy link
Author

arthabus commented Mar 6, 2021

I guess adding (val !== val) to isScalar can fix that (this expression returns true in case of NaN)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant