Close on click?

[marclennox]

I just discovered this project today. Very awesome! I've been looking for a solution for both Date and Time of Day for a while and this one is both functional and dead easy to setup.

Is there a way to have the date picker dismiss upon selection of a date. What about dismissing when the user presses the ESC key?

Thanks!

[jockmac22]

Thanks!! This is a good suggestion. I'll see if I can fit in an update here soon.

[rossriley]

For reference, all you need to do to make it disappear on select is add the following line after line 598:

                dp.hide();

[jockmac22]

Thanks rossriley.

I'm trying to carve out some time to make this a configured option for the display. My job has allowed me to make some mods to the code base and justify the time, unfortunately, this one hasn't been one of them.

[rossriley]

No worries, that was more aimed at the OP if he wanted to get it working immediately...

I'm using this in a project at the mo, so I'll try and sort it and send you a pull request if that would help.

[jockmac22]

That would be awesome if you can get it in there. Thanks!

[marclennox]

I don't mind doing this either. Let me know and I can do the PR
On Mar 26, 2014 12:39 PM, "Jocko" [email protected] wrote:

That would be awesome if you can get it in there. Thanks!

Reply to this email directly or view it on GitHubhttps://github.com//issues/2#issuecomment-38707363
.

[jockmac22]

rossriley, if you're already in process on this fix, let us know.

Otherwise marclennox, I would say that if it's going to help your process to implement it now, go ahead and then submit the pull request when you're done.

If I see two pull requests I'll roll a 2-sided die and see who gets it. ;)

[marclennox]

I put in a pull request, so I guess I win! :)

On 26 March 2014 13:19, Jocko [email protected] wrote:

rossriley, if you're already in process on this fix, let us know.

Otherwise marclennox, I would say that if it's going to help your process
to implement it now, go ahead and then submit the pull request when you're
done.

If I see two pull requests I'll roll a 2-sided die and see who gets it. ;)

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/2#issuecomment-38712509
.