Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warnings_as_errors for the sake of Erlang 21.x #128

Open
jonasrichard opened this issue Jul 6, 2018 · 3 comments
Open

Remove warnings_as_errors for the sake of Erlang 21.x #128

jonasrichard opened this issue Jul 6, 2018 · 3 comments

Comments

@jonasrichard
Copy link

Since ssl:ssl_accept is deprecated chatterbox cannot be compiled as a dependency because of this.

https://github.com/joedevivo/chatterbox/blob/master/rebar.config#L5

It would be a good idea to either remove this compile option or use ssl:ssl_handshake (I don't know how difficult it is).

@ferd
Copy link

ferd commented Jul 6, 2018

As a workaround, using the latest rebar3, you can use:

{overrides, [
    %% For all apps:
    {del, [{erl_opts, [warning_as_errors]}]},
    %% Or for just one app:
    {del, one_app, [{erl_opts, [warning_as_errors]}]}
]}.

to work around it if using this app as a dependency.

@tsloughter
Copy link
Collaborator

I fix this in my PR #127 with macros so that it just depends on what OTP you are building against for which it uses.

Just waiting to get it fully reviewed before merging.

@varoun
Copy link

varoun commented Oct 26, 2018

As a workaround, using the latest rebar3, you can use:

{overrides, [
    %% For all apps:
    {del, [{erl_opts, [warning_as_errors]}]},
    %% Or for just one app:
    {del, one_app, [{erl_opts, [warning_as_errors]}]}
]}.

to work around it if using this app as a dependency.

The correct override is as follows:

{overrides, [
    %% For all apps:
    {del, [{erl_opts, [warnings_as_errors]}]},
    %% Or for just one app:
    {del, one_app, [{erl_opts, [warnings_as_errors]}]}
]}.

Basically, s/warning/warnings/ ... This tripped me up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants