Cookies set with `StorageDomain.setCookies` are not sent with `Page.goto()`

[jschneider]

Version

5.3.1-1170846

What happened?

Since 5.0 "pageSession.network.setCookie" is deprecated.
I tried to replace it with pageSession.storage.setCookies(

The cookies seem to be set. At least pageSession.storage.getCookies( returns plausible values.

But the set cookies are not sent to the server when calling page.goto.

Setting the cookie the "old" way works as expected.

Another thing: I could not get the "expires" value to work. Maybe this is related?

Reproduction and additional details

No response

Kotlin target platforms

JVM, Kotlin 1.8

[joffrey-bion]

Hi @jschneider, thank you so much for the report.

Since 5.0 "pageSession.network.setCookie" is deprecated.

How did you infer this? This library generates domain APIs based on the official protocol definitions, and this includes deprecations. I double checked, and only the success boolean property of the SetCookieResponse type is deprecated at the moment in v5 of chrome-devtools-kotlin, which seems to match what the latest protocol version defines (see https://chromedevtools.github.io/devtools-protocol/tot/Network/#method-setCookie).

So you should still be able to use setCookie freely if that works better for you.

But the set cookies are not sent to the server when calling page.goto.

Regarding this, I'm not sure what the expected behaviour should be. The definition of the Storage.setCookies command is very vague (it's just "Sets given cookies.").
I'll investigate further what should happen here, but I'm not sure I'll be able to find an answer. These domain commands are simply "translated" to the Chrome DevTools Protocol format and sent over to Chrome (expect for the higher-level helpers), so I'm not sure there is anything that this library could do differently here.
The only potential source of problems that I see between this setCookies command and goto is the way we use browserContextId (using a different context ID might prevent cookies from being sent)

[jschneider]

Ok, thanks mate!
I somehow misread the deprecated annotation. Sorry for that.

I will stick to network.setCookie().

[joffrey-bion]

I somehow misread the deprecated annotation. Sorry for that.

No problem at all. I'm glad your problem is solved (or rather not really a problem for you anymore).

Since the main topic of this issue is actually about the StorageDomain.setCookies function not behaving as expected, I will re-open this issue to track the investigation of how this command interacts with browser contexts and goto.