Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor pvc_cap() changes #2

Open
2 tasks
jon-gilbert opened this issue Jan 25, 2023 · 0 comments
Open
2 tasks

Minor pvc_cap() changes #2

jon-gilbert opened this issue Jan 25, 2023 · 0 comments

Comments

@jon-gilbert
Copy link
Owner

jon-gilbert commented Jan 25, 2023 •
edited
Loading

Two identified todos for pvc_cap():

  • a cap perhaps doesn't need to have the same wall thickness as the pipe it's being attached to.
    Maybe? I'm not sure it matters to the construction of the model, its use with other parts, or functionally in the real world.
  • caps probably also have a slightly domed top.
    This is based on what's seen in person at the local hardware store. This is an aesthetic change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jon-gilbert