Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new magic methods in PHP 7.4 #249

Open
mbabker opened this issue Jul 6, 2019 · 3 comments
Open

Support new magic methods in PHP 7.4 #249

mbabker opened this issue Jul 6, 2019 · 3 comments

Comments

@mbabker
Copy link
Contributor

mbabker commented Jul 6, 2019

PHP 7.4 introduces two new magic methods, __serialize and __unserialize. Introducing support for this has broken PHPCS on the relevant repos because the Joomla.NamingConventions.ValidFunctionName.MethodDoubleUnderscore sniff does not know about these new methods.

@photodude
Copy link
Contributor

Does the newer versions of PHPCS v3.4.x work with it?

@zero-24
Copy link
Contributor

zero-24 commented Jul 23, 2019

hmm should't we be able to extend the $this->magicMethods array ourself as workaround?

@mbabker
Copy link
Contributor Author

mbabker commented Jul 23, 2019

You'll have to for the Joomla Coding Standards 2.x ruleset at a minimum unless you basically say that will never be PHP 7.4 friendly (AFAIK PHP_CodeSniffer isn't supporting 2.x anymore). For 3.x, the minimum PHP_CodeSniffer version can be bumped to something that supports it when available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants