-
Notifications
You must be signed in to change notification settings - Fork 5
Open
Description
As soon as you change your main docker-compose.yml file, because it is versioned controlled:
→ git status
On branch master
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: docker-compose.yml
→ git pull --rebase
error: cannot pull with rebase: You have unstaged changes.
error: please commit or stash them.
This would prevent a user pulling the latest changes to the joomlatools-server, or contributing via Pull Request without first stashing or removing local changes.
It might be better to version control docker-compose.yml
as the generic options, and then make use of a docker compose override file:
https://docs.docker.com/compose/extends/
Therefore as standard the joomlatools-server could ship with:
- docker-compose.yml
- sample-docker-compose-override.yml
Renaming sample-docker-compose-override.yml
to docker-compose-override.yml
would enable the JT server to pick up these changes during docker compose up
.
Metadata
Metadata
Assignees
Labels
No labels