Skip to content

Commit 08928c7

Browse files
committed
Stop Jackson serialising empty elements #76
1 parent c235d78 commit 08928c7

File tree

3 files changed

+6
-1
lines changed

3 files changed

+6
-1
lines changed

jackson/src/main/java/org/linguafranca/pwdb/kdbx/jackson/JacksonDatabase.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -194,6 +194,9 @@ public boolean shouldProtect(String s) {
194194
}
195195

196196
public List<KeePassFile.Binary> getBinaries() {
197+
if (keePassFile.meta.binaries == null) {
198+
keePassFile.createBinaries();
199+
}
197200
return keePassFile.meta.binaries;
198201
}
199202

jackson/src/main/java/org/linguafranca/pwdb/kdbx/jackson/JacksonSerializableDatabase.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717

1818
import com.ctc.wstx.api.WstxInputProperties;
1919
import com.ctc.wstx.api.WstxOutputProperties;
20+
import com.fasterxml.jackson.annotation.JsonInclude;
2021
import com.fasterxml.jackson.databind.DeserializationFeature;
2122
import com.fasterxml.jackson.databind.MapperFeature;
2223
import com.fasterxml.jackson.databind.SerializationFeature;
@@ -98,6 +99,7 @@ public void save(OutputStream outputStream) {
9899
mapper.enable(ToXmlGenerator.Feature.WRITE_XML_DECLARATION);
99100
mapper.enable(SerializationFeature.INDENT_OUTPUT);
100101
mapper.disable(SerializationFeature.FAIL_ON_EMPTY_BEANS);
102+
mapper.setSerializationInclusion(JsonInclude.Include.NON_EMPTY);
101103

102104
// set the serializer to Woodstox
103105
System.setProperty("javax.xml.stream.XMLOutputFactory", "com.ctc.wstx.stax.WstxOutputFactory");

kdbx/src/main/resources/base.kdbx.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
<KeePassFile>
1818
<Meta>
19-
<Generator>Keepass-Java-2</Generator>
19+
<Generator>KeePassJava2</Generator>
2020
<HeaderHash></HeaderHash>
2121
<DatabaseName>New Database</DatabaseName>
2222
<DatabaseNameChanged>${creationDate}</DatabaseNameChanged>

0 commit comments

Comments
 (0)