Skip to content

Commit a7c5cb1

Browse files
authored
Merge pull request #1550 from joreilly/fix-build-error
force a more recent version of tink
2 parents 6e31182 + 0072a1f commit a7c5cb1

File tree

5 files changed

+26
-13
lines changed

5 files changed

+26
-13
lines changed

androidApp/build.gradle.kts

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -113,18 +113,18 @@ android {
113113

114114
matchingFallbacks += listOf("release")
115115
}
116-
// create("benchmark") {
117-
// isShrinkResources = true
118-
// isMinifyEnabled = true
119-
// signingConfig = signingConfigs.getByName("confetti")
120-
// setProguardFiles(
121-
// listOf(
122-
// getDefaultProguardFile("proguard-android.txt"),
123-
// "proguard-benchmark.pro"
124-
// )
125-
// )
126-
// matchingFallbacks.addAll(listOf("release"))
127-
// }
116+
create("benchmark") {
117+
isShrinkResources = true
118+
isMinifyEnabled = true
119+
signingConfig = signingConfigs.getByName("confetti")
120+
setProguardFiles(
121+
listOf(
122+
getDefaultProguardFile("proguard-android.txt"),
123+
"proguard-benchmark.pro"
124+
)
125+
)
126+
matchingFallbacks.addAll(listOf("release"))
127+
}
128128
getByName("debug") {
129129
signingConfig = signingConfigs.getByName("confetti")
130130
}

build-logic/build.gradle.kts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,9 @@ dependencies {
2323
// Crashlytics depends on datastore v1.0 but we're using v1.1
2424
exclude(group = "androidx.datastore", module = "datastore-preferences")
2525
}
26+
// Force a newer version of tink in the classpath for compatibility with protobuf-java:4.x
27+
// Removes java.lang.NoSuchMethodError: 'void com.google.crypto.tink.proto.Keyset.makeExtensionsImmutable()'
28+
implementation(libs.tink)
2629
implementation(libs.plugin.wire)
2730
implementation(libs.plugin.compose.multiplatform)
2831
implementation(libs.jib.core)

gradle/libs.versions.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ wear-compose-material = "androidx.wear.compose:compose-material:1.5.0-alpha11"
206206
wear-compose-material3 = "androidx.wear.compose:compose-material3:1.0.0-alpha34"
207207
xoxo = "net.mbonnin.xoxo:xoxo:0.4.0"
208208
kermit = { module = "co.touchlab:kermit", version.ref = "kermit" }
209-
209+
tink = "com.google.crypto.tink:tink:1.17.0"
210210
jib-core = "com.google.cloud.tools:jib-core:0.27.2"
211211
google-cloud-run = "com.google.cloud:google-cloud-run:0.54.0"
212212

wearApp/src/main/res/values-fr/strings.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,4 +27,8 @@
2727
<string name="settings_empty_name">empty name</string>
2828
<string name="home_bookmarked_sessions">Bookmarked Sessions</string>
2929
<string name="home_settings_content_description">Settings</string>
30+
<string name="settings_allow_lte">Autoriser le LTE</string>
31+
<string name="settings_show_networks">Afficher les réseaux</string>
32+
<string name="settings_show_networks_and_data">Afficher les réseaux et la data</string>
33+
<string name="settings_hide_networks">Masquer les réseaux</string>
3034
</resources>

wearApp/src/screenshotTest/java/dev/johnoreilly/confetti/wear/ConferenceHomeScreenTest.kt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@ fun ConferenceHomeScreen() {
3535
daySelected = {},
3636
onSettingsClick = {},
3737
onBookmarksClick = {},
38+
addBookmark = {},
39+
removeBookmark = {}
3840
)
3941
}
4042

@@ -72,6 +74,8 @@ fun ConferenceHomeScreenWithBookmarks() {
7274
daySelected = {},
7375
onSettingsClick = {},
7476
onBookmarksClick = {},
77+
addBookmark = {},
78+
removeBookmark = {}
7579
)
7680
}
7781

@@ -93,6 +97,8 @@ fun ConferenceHomeScreenLoading() {
9397
daySelected = {},
9498
onSettingsClick = {},
9599
onBookmarksClick = {},
100+
addBookmark = {},
101+
removeBookmark = {}
96102
)
97103
}
98104

0 commit comments

Comments
 (0)