Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose the DEBUG_HEADERS configuration #29

Open
2 tasks
jorgelbg opened this issue Feb 17, 2021 · 0 comments
Open
2 tasks

Expose the DEBUG_HEADERS configuration #29

jorgelbg opened this issue Feb 17, 2021 · 0 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@jorgelbg
Copy link
Owner

jorgelbg commented Feb 17, 2021 •
edited
Loading

Now that label cardinality is no longer an issue since the actual labels sent to Loki are limited. We can expose the DEBUG_HEADERS configuration option that allows logging all request/response headers.

The code has been there since the beginning but storing everything as labels had a big performance impact when querying. Also, it was quite common to hit the default maximum number of allowed labels by Loki.

  • Expose a DEBUG configuration to the worker settings.
  • Add a note to the README about this option.
@jorgelbg jorgelbg added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jorgelbg