Skip to content

Commit d25c529

Browse files
committed
disable log.showSignature config for git commands by default
gitlint doesnt work properly if the global configuration of the users enables log.showSignature config. See below as an example: ```  git log commit 4d91197 (HEAD -> main, upstream/main, upstream/HEAD) gpg: Signature made Sat 02 Sep 2023 08:25:48 AM UTC gpg: using RSA key 4AEE18F83AFDEB23 gpg: Can't check signature: No public key Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Sat Sep 2 10:25:48 2023 +0200 Bump python from 3.11.4-alpine to 3.11.5-alpine (#525) Bumps python from 3.11.4-alpine to 3.11.5-alpine. --- updated-dependencies:  gitlint An error occurred while executing 'git log gpg: Signature made Sat 02 Sep 2023 08:25:48 AM UTCgpg: using RSA key 4AEE18F83AFDEB23gpg: Can't check signature: No public key4d9119760056492eabc201bfad5de2f9e660b85f -1 --pretty=%aN%x00%aE%x00%ai%x00%P%n%B': b"fatal: invalid object name 'gpg'." ``` After disabling log.showSignature config for git runs made by gitlint, it works as expected. ```  hatch run dev:gitlint An error occurred while executing 'git log gpg: Signature made Sat 02 Sep 2023 08:25:48 AM UTCgpg: using RSA key 4AEE18F83AFDEB23gpg: Can't check signature: No public key4d9119760056492eabc201bfad5de2f9e660b85f -1 --pretty=%aN%x00%aE%x00%ai%x00%P%n%B': b"fatal: invalid object name 'gpg'." ^^ this is before fix in dev environment  hatch run dev:gitlint ^^ this is after fix as expected ```
1 parent 4d91197 commit d25c529

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

gitlint-core/gitlint/shell.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ def git(*command_parts: str, **kwargs: Any) -> ShResult:
4242
Implemented as separate function here, so we can do a 'sh' style imports:
4343
`from shell import git`
4444
"""
45-
args = ["git", *list(command_parts)]
45+
default_configs = [ "-c", "log.showSignature=false" ]
46+
args = ["git", *default_configs, *list(command_parts)]
4647
return _exec(*args, **kwargs)
4748

4849

0 commit comments

Comments
 (0)