feat: [torrust#1096] reset IP banning list for connections errors every hour

Author: josecelano

src/servers/udp/server/launcher.rs

@@ -3,7 +3,7 @@ use std::sync::Arc;
 use std::time::Duration;
 
 use bittorrent_tracker_client::udp::client::check;
-use bloom::CountingBloomFilter;
+use bloom::{CountingBloomFilter, ASMS};
 use derive_more::Constructor;
 use futures_util::StreamExt;
 use tokio::select;
@@ -24,6 +24,7 @@ use crate::servers::udp::UDP_TRACKER_LOG_TARGET;
 /// The maximum number of connection id errors per ip. Clients will be banned if
 /// they exceed this limit.
 const MAX_CONNECTION_ID_ERRORS_PER_IP: u32 = 10;
+const RESET_CONNECTION_ID_ERRORS_COUNTER_FREQUENCY_IN_SECS: u64 = 3600;
 
 /// A UDP server instance launcher.
 #[derive(Constructor)]
@@ -123,12 +124,24 @@ impl Launcher {
         // false positive rate of 0.01 when 100 items have been inserted
         let connection_id_errors_per_ip = Arc::new(RwLock::new(CountingBloomFilter::with_rate(4, 0.01, 100)));
 
+        // Timer to track when to clear the filter
+        let mut last_connection_id_errors_reset = tokio::time::Instant::now();
+
         let addr = receiver.bound_socket_address();
+
         let local_addr = format!("udp://{addr}");
 
         let cookie_lifetime = cookie_lifetime.as_secs_f64();
 
         loop {
+            if last_connection_id_errors_reset.elapsed()
+                >= Duration::from_secs(RESET_CONNECTION_ID_ERRORS_COUNTER_FREQUENCY_IN_SECS)
+            {
+                connection_id_errors_per_ip.write().await.clear();
+                tracing::info!(target: UDP_TRACKER_LOG_TARGET, local_addr, "Udp::run_udp_server::loop (connection id errors filter cleared)");
+                last_connection_id_errors_reset = tokio::time::Instant::now();
+            }
+
             let processor = Processor::new(receiver.socket.clone(), tracker.clone(), cookie_lifetime);
 
             if let Some(req) = {