feat: [torrust#1456] wrapper over aquatic RequestParseError to make it sendable

The error will be included in the UdpError event ans sent via tokio
channel.

Author: josecelano

packages/udp-tracker-server/src/error.rs

@@ -1,7 +1,7 @@
 //! Error types for the UDP server.
 use std::panic::Location;
 
-use aquatic_udp_protocol::{ConnectionId, RequestParseError};
+use aquatic_udp_protocol::{ConnectionId, RequestParseError, TransactionId};
 use bittorrent_udp_tracker_core::services::announce::UdpAnnounceError;
 use bittorrent_udp_tracker_core::services::scrape::UdpScrapeError;
 use derive_more::derive::Display;
@@ -17,7 +17,7 @@ pub struct ConnectionCookie(pub ConnectionId);
 pub enum Error {
     /// Error returned when the request is invalid.
     #[error("error when phrasing request: {request_parse_error:?}")]
-    RequestParseError { request_parse_error: RequestParseError },
+    RequestParseError { request_parse_error: SendableRequestParseError },
 
     /// Error returned when the domain tracker returns an announce error.
     #[error("tracker announce error: {source}")]
@@ -47,7 +47,9 @@ pub enum Error {
 
 impl From<RequestParseError> for Error {
     fn from(request_parse_error: RequestParseError) -> Self {
-        Self::RequestParseError { request_parse_error }
+        Self::RequestParseError {
+            request_parse_error: request_parse_error.into(),
+        }
     }
 }
 
@@ -66,3 +68,29 @@ impl From<UdpScrapeError> for Error {
         }
     }
 }
+
+#[derive(Debug, PartialEq, Eq, Clone)]
+pub struct SendableRequestParseError {
+    pub message: String,
+    pub opt_connection_id: Option<ConnectionId>,
+    pub opt_transaction_id: Option<TransactionId>,
+}
+
+impl From<RequestParseError> for SendableRequestParseError {
+    fn from(request_parse_error: RequestParseError) -> Self {
+        let (message, opt_connection_id, opt_transaction_id) = match request_parse_error {
+            RequestParseError::Sendable {
+                connection_id,
+                transaction_id,
+                err,
+            } => ((*err).to_string(), Some(connection_id), Some(transaction_id)),
+            RequestParseError::Unsendable { err } => (err.to_string(), None, None),
+        };
+
+        Self {
+            message,
+            opt_connection_id,
+            opt_transaction_id,
+        }
+    }
+}

packages/udp-tracker-server/src/handlers/error.rs

@@ -2,8 +2,7 @@
 use std::net::SocketAddr;
 use std::ops::Range;
 
-use aquatic_udp_protocol::{ErrorResponse, RequestParseError, Response, TransactionId};
-use bittorrent_udp_tracker_core::connection_cookie::{check, gen_remote_fingerprint};
+use aquatic_udp_protocol::{ErrorResponse, Response, TransactionId};
 use bittorrent_udp_tracker_core::{self, UDP_TRACKER_LOG_TARGET};
 use torrust_tracker_primitives::service_binding::ServiceBinding;
 use tracing::{instrument, Level};
@@ -40,25 +39,14 @@ pub async fn handle_error(
     }
 
     let e = if let Error::RequestParseError { request_parse_error } = e {
-        match request_parse_error {
-            RequestParseError::Sendable {
-                connection_id,
-                transaction_id,
-                err,
-            } => {
-                if let Err(e) = check(connection_id, gen_remote_fingerprint(&client_socket_addr), cookie_valid_range) {
-                    (e.to_string(), Some(*transaction_id))
-                } else {
-                    ((*err).to_string(), Some(*transaction_id))
-                }
-            }
-            RequestParseError::Unsendable { err } => (err.to_string(), transaction_id),
-        }
+        (request_parse_error.message.clone(), transaction_id)
     } else {
         (e.to_string(), transaction_id)
     };
 
     if e.1.is_some() {
+        // code-review: why we trigger an event only if transaction_id is present?
+
         if let Some(udp_server_stats_event_sender) = opt_udp_server_stats_event_sender.as_deref() {
             udp_server_stats_event_sender
                 .send(Event::UdpError {