refactor: [torrust#1456] remove unused enum variant in udp server error

Author: josecelano

Cargo.lock

@@ -30,7 +30,6 @@ torrust-server-lib = { version = "3.0.0-develop", path = "../server-lib" }
 torrust-tracker-clock = { version = "3.0.0-develop", path = "../clock" }
 torrust-tracker-configuration = { version = "3.0.0-develop", path = "../configuration" }
 torrust-tracker-events = { version = "3.0.0-develop", path = "../events" }
-torrust-tracker-located-error = { version = "3.0.0-develop", path = "../located-error" }
 torrust-tracker-metrics = { version = "3.0.0-develop", path = "../metrics" }
 torrust-tracker-primitives = { version = "3.0.0-develop", path = "../primitives" }
 torrust-tracker-swarm-coordination-registry = { version = "3.0.0-develop", path = "../swarm-coordination-registry" }

packages/udp-tracker-server/Cargo.toml

@@ -7,7 +7,6 @@ use bittorrent_udp_tracker_core::services::announce::UdpAnnounceError;
 use bittorrent_udp_tracker_core::services::scrape::UdpScrapeError;
 use derive_more::derive::Display;
 use thiserror::Error;
-use torrust_tracker_located_error::LocatedError;
 
 #[derive(Display, Debug)]
 #[display(":?")]
@@ -35,12 +34,6 @@ pub enum Error {
         message: String,
     },
 
-    /// Error returned when the request is invalid.
-    #[error("bad request: {source}")]
-    BadRequest {
-        source: LocatedError<'static, dyn std::error::Error + Send + Sync>,
-    },
-
     /// Error returned when tracker requires authentication.
     #[error("domain tracker requires authentication but is not supported in current UDP implementation. Location: {location}")]
     TrackerAuthenticationRequired { location: &'static Location<'static> },

packages/udp-tracker-server/src/error.rs

@@ -146,7 +146,6 @@ impl From<Error> for ErrorKind {
                 UdpScrapeError::TrackerCoreWhitelistError { source } => Self::Whitelist(source.to_string()),
             },
             Error::InternalServer { location: _, message } => Self::InternalServer(message.to_string()),
-            Error::BadRequest { source } => Self::BadRequest(source.to_string()),
             Error::TrackerAuthenticationRequired { location } => Self::TrackerAuthentication(location.to_string()),
         }
     }

packages/udp-tracker-server/src/event.rs

@@ -109,6 +109,7 @@ pub(crate) async fn handle_packet(
                 }
             },
             Err(e) => {
+                // The request payload could not be parsed, so we handle it as an error.
                 let response = handle_error(
                     None,
                     udp_request.from,