Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a function to hide or show all players at the same times #209

Open
HydrolienF opened this issue Apr 20, 2024 · 3 comments
Open

Add a function to hide or show all players at the same times #209

HydrolienF opened this issue Apr 20, 2024 · 3 comments

Comments

@HydrolienF
Copy link

It would be nice to have a /squaremap show all and /squaremap hide all.

@jpenilla
Copy link
Owner

jpenilla commented Apr 21, 2024

The hidden status is stored in the player data, so we can't do anything about offline players. This means hiding and showing all is not a reversible action if the players online changes in between. This would lead to unexpected behavior and so isn't something I want to include. On Fabric & NeoForge you should be able to use /execute to run the command as each online player. On Paper you would need to use the API.

@jpenilla
Copy link
Owner

On second thought, I guess this could be a command that just toggles the player tracker at runtime, which could actually be useful

@jpenilla jpenilla reopened this Apr 21, 2024
@HydrolienF
Copy link
Author

The solution that I will prefer is a config option that have 3 values: forced_show, forced_hide, player_setting. (Could be editable through command tho).

  • player_setting is the current behavior where it use visibility stored on player data.
  • forced_visible will make player visible no mater if they have run /map hide
  • forced_show will make player visible no mater if they have run /map show

If you agree with that new feature, I can try to do it and send a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants