Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback wanted: show_x url params persist when copying link #319

Open
jpenilla opened this issue Oct 17, 2024 · 3 comments
Open

Feedback wanted: show_x url params persist when copying link #319

jpenilla opened this issue Oct 17, 2024 · 3 comments

Comments

@jpenilla
Copy link
Owner

When using the link ui to copy a link, the params for hiding and showing elements are persisted. Not 100% sure if this is desirable, there is valid reasoning for both ways. Should we add another parameter to control this, keep it, or revert it (not persist)? Please comment if you have thoughts on this.

see #315

@Chucky3920
Copy link
Contributor

I think it should persist the show_x stuff, because its pretty annoying typing it out everytime + right now you type it out manually

@jpenilla
Copy link
Owner Author

The reason I was thinking it shouldn't persist would be if someone disabled all the UI elements except for the link button, they may want to use it as a way to get a link to the full map as opposed to the iframe view with elements disabled. Since you think we should keep the persistence, maybe a separate parameter to control this would be best.

@Chucky3920
Copy link
Contributor

Sure, I just needed this for my iframe because my iframe is tiny and the sidebar and stuff just clutters the screen when it's 150x150px

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants