FormData fails all calls - testing solution but can't make it work at all

[UXDart]

Hello. using the latest npm version, any FormData usage doesn't reply, or not sure the problem. to see what happens, I downloaded zip of the repo and copied src to my project, but using

import xhook from './src/libs/xhook/main';

it seems to be doing something, but all requests are blocked. same with using .before... I can't use it in this way? I mean directly in my code? if I can make it work that way, I can see where the problem is... any tip?

Thanks

[jpillora]

have you tried using npm and import xhook from 'xhook' ?

@TrickyPi not sure if this is a bug or not...

[TrickyPi]

@UXDart Could you provide a minimal reproducible repo? I guess the reason all requests are blocked is that your before function is incorrect, see here

[UXDart]

Thanks! if I use npm module directly, it works, but I have the same problem different people mentioned years ago about not working for FormData...
to debug the issue, I tried to use the source code directly, and doesn't work at all, with the same "before" method, it was working for non FormData calls using npm. if I remove the before call also, it doesn't work (without any after call). Thanks

[UXDart]

I read before this #152 there is a reason that using the source code in my project won't work?

[TrickyPi]

Hmmm, it works if you use source code in your project, but I recommend using yarn link or npm link to debug the source code.

[TrickyPi]

Could you provide a minimal reproducible repo or reproducible steps?

[UXDart]

found the problem, I added
import xhook from '../main';

to
xmlhttprequest.js

it is using inside xhook as it is already defined but it is not

[UXDart]

now I have another problem it seems here

https://github.com/jpillora/xhook/blob/main/src/patch/xmlhttprequest.js#L210

if I remove those lines then a call to google analytics seems to work, if I leave it setting withCredentials to false, I assume it must be true... what is the purpose of those lines?
Thanks

[TrickyPi]

The default is false, see https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/withCredentials

[UXDart]

ok, but if. ""withCredentials" in xhr" is there, it means the property is there, it could have the value true... we are setting to false anyway

[UXDart]

the issue is, intercepting a call from google analytics using cors and credentials fails to connect, if I comment that line it works

[TrickyPi]

I think it can be overridden by xhr.withCredentials=true, like so https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/withCredentials#examples

[UXDart]

yes, but what I mean, I can be wrong... if the xhr already has withCredentials true, we are setting it to false in that line

[UXDart]

I mean, it is checking the if the property is there (field in xhr) but it is not checking if the value is true

[TrickyPi]

if the xhr already has withCredentials true, we are setting it to false in that line

That's impossible, we only set the value of withCredentials to false when creating the xhr.