Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telnetlib3.open_connection timeout #30

Open
morfair opened this issue Jan 12, 2018 · 2 comments
Open

telnetlib3.open_connection timeout #30

morfair opened this issue Jan 12, 2018 · 2 comments

Comments

@morfair
Copy link

morfair commented Jan 12, 2018

How to set timeout for open_connection()?

@parmentelat
Copy link

parmentelat commented May 30, 2019

I'd like to +1 this one

my use case is that when remote server is up (which is not always the case) then it is expected to answer promptly; in that case we engage in a session that may last for some time - typically for ghosting system images, so we're talking minutes

OTOH when the node is down, I don't need to wait for more than 1 second before I decide it's not worth the wait

given that a call to open_connection will last for the whole duration of the session, I can't use asyncio.wait_for on a call to open_connection as that would fire in normal conditions too

I can't seem to find a reference to a create_connection, that would I believe be a nice angle here; or am I missing something ?

edit: this is about version 1.0.2

@jquast
Copy link
Owner

jquast commented Feb 4, 2021

understood, it is needed yes, PRs welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants