Skip to content

Commit 2232191

Browse files
committed
reorg(modeling): reworked some create functions to use JS defaults
1 parent 30ffad9 commit 2232191

File tree

5 files changed

+5
-31
lines changed

5 files changed

+5
-31
lines changed

jsdoc.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
"packages/modeling/src/geometries/geom2",
1111
"packages/modeling/src/geometries/geom3",
1212
"packages/modeling/src/geometries/path2",
13+
"packages/modeling/src/geometries/path3",
1314
"packages/modeling/src/geometries/poly2",
1415
"packages/modeling/src/geometries/poly3",
1516
"packages/modeling/src/geometries/slice",

packages/modeling/src/geometries/geom3/create.js

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,4 @@ import * as mat4 from '../../maths/mat4/index.js'
2424
* @returns {Geom3} a new geometry
2525
* @alias module:modeling/geometries/geom3.create
2626
*/
27-
export const create = (polygons) => {
28-
if (polygons === undefined) {
29-
polygons = [] // empty contents
30-
}
31-
return {
32-
polygons,
33-
transforms: mat4.create()
34-
}
35-
}
27+
export const create = (polygons = []) => ({ polygons, transforms: mat4.create() })

packages/modeling/src/geometries/path2/create.js

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -21,13 +21,4 @@ import * as mat4 from '../../maths/mat4/index.js'
2121
* @example
2222
* let newPath = create()
2323
*/
24-
export const create = (points) => {
25-
if (points === undefined) {
26-
points = []
27-
}
28-
return {
29-
points: points,
30-
isClosed: false,
31-
transforms: mat4.create()
32-
}
33-
}
24+
export const create = (points = []) => ({ points: points, isClosed: false, transforms: mat4.create() })

packages/modeling/src/geometries/poly2/create.js

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,4 @@
1515
* @example
1616
* let polygon = create([[0,0], [4,0], [4,3]])
1717
*/
18-
export const create = (points) => {
19-
if (points === undefined || points.length < 3) {
20-
points = [] // empty contents
21-
}
22-
return { points }
23-
}
18+
export const create = (points = []) => ({ points })

packages/modeling/src/geometries/poly3/create.js

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,4 @@
1616
* @example
1717
* const polygon = create([[1, 0], [0, 1], [0, 0]])
1818
*/
19-
export const create = (vertices) => {
20-
if (vertices === undefined || vertices.length < 3) {
21-
vertices = [] // empty contents
22-
}
23-
return { vertices }
24-
}
19+
export const create = (vertices = []) => ({ vertices })

0 commit comments

Comments
 (0)