Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better range comparisons #4

Open
guybedford opened this issue Jul 18, 2021 · 0 comments
Open

Better range comparisons #4

guybedford opened this issue Jul 18, 2021 · 0 comments

Comments

@guybedford
Copy link
Member

For the range comparison:

const r1 = new SemverRange('^1.2.3');
const r2 = new SemverRange('~1.2.5');

r1.gt(r2);

currently this will return false, when we should really be returning true for this case. That is, range comparisons should be based on comparing the upper bound not the lower bound.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant