Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignoreHistoryAndEvents option does not work when using setStyle #1722

Closed
JHA-ko opened this issue Jan 10, 2025 · 1 comment
Closed

ignoreHistoryAndEvents option does not work when using setStyle #1722

JHA-ko opened this issue Jan 10, 2025 · 1 comment

Comments

@JHA-ko
Copy link

JHA-ko commented Jan 10, 2025

Hi,
When calling setStyle(), the ignoreHistoryAndEvents option does not work. After checking the worksheet.js file, I noticed that the setStyle function is missing the ignoreHistoryAndEvents parameter.

['setStyle', function(cell, property, value, forceOverwrite, ignoreHistoryAndEvents) {
return setStyle.call(this, cell, property, value, forceOverwrite, ignoreHistoryAndEvents);
}],

After applying this fix and testing, the option works as expected. Please review and consider applying this change.

@Ruan-Miguel
Copy link
Collaborator

Ruan-Miguel commented Jan 23, 2025

This argument was removed on version 5, instead of using it, set the value of the worksheet.ignoreHistory property to true before using setStyle and return the value of the worksheet.ignoreHistory property to false right after setStyle.

@hodeware hodeware closed this as completed Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants