Skip to content

Commit b6e3ee6

Browse files
committed
maint: remove playwright/galata ui tests
1 parent 3aa5221 commit b6e3ee6

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

69 files changed

+5050
-14447
lines changed

doc/development.qmd

Lines changed: 1 addition & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,6 @@ The result is put into `src/pyobsplot/static`.
4747

4848
## Tests
4949

50-
`pyobsplot` comes with three types of tests : Python test, JavaScript tests and Visual regression tests.
51-
5250
To run Python tests, use:
5351

5452
```sh
@@ -61,26 +59,6 @@ To run JavaScript tests, use:
6159
npm run test --workspaces
6260
```
6361

64-
Visual regression tests allow to test if generated plots stay the same. They use the [galata](https://github.com/jupyterlab/jupyterlab/tree/master/galata) framework. To run them you first have to start a specific Jupyter instance with:
65-
66-
```sh
67-
npm run uistart
68-
```
69-
70-
If you use visual regression tests for the first time, you have to generate reference images with:
71-
72-
```sh
73-
# Create / update reference images
74-
npm run uitest:update
75-
```
76-
77-
After that, you can test that currently generated images are the same as the reference one with:
78-
79-
```sh
80-
# Compare with reference images
81-
npm run uitest
82-
```
83-
8462
## Debug mode
8563

8664
"Debug mode" outputs the computed JavaScript plot structure (the one passed to `Plot.plot`).
@@ -122,4 +100,4 @@ uv run quarto render doc/
122100
When a new Plot version is released:
123101

124102
- update with `npm install @observablehq/plot d3 --workspaces --include-workspace-root`
125-
- run `utils/get_plot_methods.js` to update Plot methods in `src/pyobsplot/plot.py`
103+
- run `utils/get_plot_methods.js` to update Plot methods in `src/pyobsplot/plot.py`

package-lock.json

Lines changed: 5046 additions & 7817 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,23 +3,16 @@
33
"@observablehq/plot": "^0.6.17",
44
"anywidget": "^0.9.0",
55
"d3": "^7.9.0",
6+
"d3-geo-projection": "^4.0.0",
67
"d3-scale-chromatic": "^3.1.0"
78
},
89
"scripts": {
910
"bundle": "esbuild --minify --format=esm --bundle --outdir=src/pyobsplot/static --entry-names=static-[name] src/js/widget.js src/js/styles.css",
1011
"dev": "npm run bundle -- --watch",
1112
"build": "npm run bundle && uv build",
12-
"test": "uv run pytest",
13-
"uistart": "uv run -- jupyter lab --config tests/ui/jupyter_server_config.py",
14-
"uitest": "npx playwright test --workers=1 --config tests/ui/playwright.config.cjs",
15-
"uitest:debug": "PWDEBUG=1 npm run uitest",
16-
"uitest:report": "http-server ./tests/ui/playwright-report -a localhost -o",
17-
"uitest:update": "npm run uitest -- --update-snapshots",
18-
"uitest:ui": "npm run uitest -- --ui"
13+
"test": "uv run pytest"
1914
},
2015
"devDependencies": {
21-
"@jupyterlab/galata": "^5.1.5",
22-
"@playwright/test": "^1.38.1",
2316
"esbuild": "^0.25.0"
2417
},
2518
"type": "module",
File renamed without changes.

tests/python/jsdom_reference/html/complex_metros_arrow.html renamed to tests/jsdom_reference/html/complex_metros_arrow.html

File renamed without changes.

tests/python/jsdom_reference/html/complex_penguins_facet.html renamed to tests/jsdom_reference/html/complex_penguins_facet.html

File renamed without changes.

0 commit comments

Comments
 (0)