Skip to content

Commit 7f4176e

Browse files
szarvasszarvas
committed
Fix potential crash in Ableton Live when dismissing the plugin window with Esc
The crash could be reproduced with a WebBrowserComponent, but it was not the root cause of it.
1 parent 86b17ef commit 7f4176e

31 files changed

+233
-0
lines changed

‎examples/DemoRunner/Builds/Android/app/CMakeLists.txt‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2135,6 +2135,8 @@ add_library( ${BINARY_NAME}
21352135
"../../../../../modules/juce_gui_basics/detail/juce_AlertWindowHelpers.h"
21362136
"../../../../../modules/juce_gui_basics/detail/juce_ButtonAccessibilityHandler.h"
21372137
"../../../../../modules/juce_gui_basics/detail/juce_ComponentHelpers.h"
2138+
"../../../../../modules/juce_gui_basics/detail/juce_ComponentPeerHelpers.cpp"
2139+
"../../../../../modules/juce_gui_basics/detail/juce_ComponentPeerHelpers.h"
21382140
"../../../../../modules/juce_gui_basics/detail/juce_CustomMouseCursorInfo.h"
21392141
"../../../../../modules/juce_gui_basics/detail/juce_FocusHelpers.h"
21402142
"../../../../../modules/juce_gui_basics/detail/juce_FocusRestorer.h"
@@ -4741,6 +4743,8 @@ set_source_files_properties(
47414743
"../../../../../modules/juce_gui_basics/detail/juce_AlertWindowHelpers.h"
47424744
"../../../../../modules/juce_gui_basics/detail/juce_ButtonAccessibilityHandler.h"
47434745
"../../../../../modules/juce_gui_basics/detail/juce_ComponentHelpers.h"
4746+
"../../../../../modules/juce_gui_basics/detail/juce_ComponentPeerHelpers.cpp"
4747+
"../../../../../modules/juce_gui_basics/detail/juce_ComponentPeerHelpers.h"
47444748
"../../../../../modules/juce_gui_basics/detail/juce_CustomMouseCursorInfo.h"
47454749
"../../../../../modules/juce_gui_basics/detail/juce_FocusHelpers.h"
47464750
"../../../../../modules/juce_gui_basics/detail/juce_FocusRestorer.h"

‎examples/DemoRunner/Builds/VisualStudio2019/DemoRunner_App.vcxproj‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2605,6 +2605,9 @@
26052605
<ClCompile Include="..\..\..\..\modules\juce_gui_basics\detail\juce_AccessibilityHelpers.cpp">
26062606
<ExcludedFromBuild>true</ExcludedFromBuild>
26072607
</ClCompile>
2608+
<ClCompile Include="..\..\..\..\modules\juce_gui_basics\detail\juce_ComponentPeerHelpers.cpp">
2609+
<ExcludedFromBuild>true</ExcludedFromBuild>
2610+
</ClCompile>
26082611
<ClCompile Include="..\..\..\..\modules\juce_gui_basics\drawables\juce_Drawable.cpp">
26092612
<ExcludedFromBuild>true</ExcludedFromBuild>
26102613
</ClCompile>
@@ -4462,6 +4465,7 @@
44624465
<ClInclude Include="..\..\..\..\modules\juce_gui_basics\detail\juce_AlertWindowHelpers.h"/>
44634466
<ClInclude Include="..\..\..\..\modules\juce_gui_basics\detail\juce_ButtonAccessibilityHandler.h"/>
44644467
<ClInclude Include="..\..\..\..\modules\juce_gui_basics\detail\juce_ComponentHelpers.h"/>
4468+
<ClInclude Include="..\..\..\..\modules\juce_gui_basics\detail\juce_ComponentPeerHelpers.h"/>
44654469
<ClInclude Include="..\..\..\..\modules\juce_gui_basics\detail\juce_CustomMouseCursorInfo.h"/>
44664470
<ClInclude Include="..\..\..\..\modules\juce_gui_basics\detail\juce_FocusHelpers.h"/>
44674471
<ClInclude Include="..\..\..\..\modules\juce_gui_basics\detail\juce_FocusRestorer.h"/>

‎examples/DemoRunner/Builds/VisualStudio2019/DemoRunner_App.vcxproj.filters‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3382,6 +3382,9 @@
33823382
<ClCompile Include="..\..\..\..\modules\juce_gui_basics\detail\juce_AccessibilityHelpers.cpp">
33833383
<Filter>JUCE Modules\juce_gui_basics\detail</Filter>
33843384
</ClCompile>
3385+
<ClCompile Include="..\..\..\..\modules\juce_gui_basics\detail\juce_ComponentPeerHelpers.cpp">
3386+
<Filter>JUCE Modules\juce_gui_basics\detail</Filter>
3387+
</ClCompile>
33853388
<ClCompile Include="..\..\..\..\modules\juce_gui_basics\drawables\juce_Drawable.cpp">
33863389
<Filter>JUCE Modules\juce_gui_basics\drawables</Filter>
33873390
</ClCompile>
@@ -7779,6 +7782,9 @@
77797782
<ClInclude Include="..\..\..\..\modules\juce_gui_basics\detail\juce_ComponentHelpers.h">
77807783
<Filter>JUCE Modules\juce_gui_basics\detail</Filter>
77817784
</ClInclude>
7785+
<ClInclude Include="..\..\..\..\modules\juce_gui_basics\detail\juce_ComponentPeerHelpers.h">
7786+
<Filter>JUCE Modules\juce_gui_basics\detail</Filter>
7787+
</ClInclude>
77827788
<ClInclude Include="..\..\..\..\modules\juce_gui_basics\detail\juce_CustomMouseCursorInfo.h">
77837789
<Filter>JUCE Modules\juce_gui_basics\detail</Filter>
77847790
</ClInclude>

‎examples/DemoRunner/Builds/VisualStudio2022/DemoRunner_App.vcxproj‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2605,6 +2605,9 @@
26052605
<ClCompile Include="..\..\..\..\modules\juce_gui_basics\detail\juce_AccessibilityHelpers.cpp">
26062606
<ExcludedFromBuild>true</ExcludedFromBuild>
26072607
</ClCompile>
2608+
<ClCompile Include="..\..\..\..\modules\juce_gui_basics\detail\juce_ComponentPeerHelpers.cpp">
2609+
<ExcludedFromBuild>true</ExcludedFromBuild>
2610+
</ClCompile>
26082611
<ClCompile Include="..\..\..\..\modules\juce_gui_basics\drawables\juce_Drawable.cpp">
26092612
<ExcludedFromBuild>true</ExcludedFromBuild>
26102613
</ClCompile>
@@ -4462,6 +4465,7 @@
44624465
<ClInclude Include="..\..\..\..\modules\juce_gui_basics\detail\juce_AlertWindowHelpers.h"/>
44634466
<ClInclude Include="..\..\..\..\modules\juce_gui_basics\detail\juce_ButtonAccessibilityHandler.h"/>
44644467
<ClInclude Include="..\..\..\..\modules\juce_gui_basics\detail\juce_ComponentHelpers.h"/>
4468+
<ClInclude Include="..\..\..\..\modules\juce_gui_basics\detail\juce_ComponentPeerHelpers.h"/>
44654469
<ClInclude Include="..\..\..\..\modules\juce_gui_basics\detail\juce_CustomMouseCursorInfo.h"/>
44664470
<ClInclude Include="..\..\..\..\modules\juce_gui_basics\detail\juce_FocusHelpers.h"/>
44674471
<ClInclude Include="..\..\..\..\modules\juce_gui_basics\detail\juce_FocusRestorer.h"/>

‎examples/DemoRunner/Builds/VisualStudio2022/DemoRunner_App.vcxproj.filters‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3382,6 +3382,9 @@
33823382
<ClCompile Include="..\..\..\..\modules\juce_gui_basics\detail\juce_AccessibilityHelpers.cpp">
33833383
<Filter>JUCE Modules\juce_gui_basics\detail</Filter>
33843384
</ClCompile>
3385+
<ClCompile Include="..\..\..\..\modules\juce_gui_basics\detail\juce_ComponentPeerHelpers.cpp">
3386+
<Filter>JUCE Modules\juce_gui_basics\detail</Filter>
3387+
</ClCompile>
33853388
<ClCompile Include="..\..\..\..\modules\juce_gui_basics\drawables\juce_Drawable.cpp">
33863389
<Filter>JUCE Modules\juce_gui_basics\drawables</Filter>
33873390
</ClCompile>
@@ -7779,6 +7782,9 @@
77797782
<ClInclude Include="..\..\..\..\modules\juce_gui_basics\detail\juce_ComponentHelpers.h">
77807783
<Filter>JUCE Modules\juce_gui_basics\detail</Filter>
77817784
</ClInclude>
7785+
<ClInclude Include="..\..\..\..\modules\juce_gui_basics\detail\juce_ComponentPeerHelpers.h">
7786+
<Filter>JUCE Modules\juce_gui_basics\detail</Filter>
7787+
</ClInclude>
77827788
<ClInclude Include="..\..\..\..\modules\juce_gui_basics\detail\juce_CustomMouseCursorInfo.h">
77837789
<Filter>JUCE Modules\juce_gui_basics\detail</Filter>
77847790
</ClInclude>

‎extras/AudioPerformanceTest/Builds/Android/app/CMakeLists.txt‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1897,6 +1897,8 @@ add_library( ${BINARY_NAME}
18971897
"../../../../../modules/juce_gui_basics/detail/juce_AlertWindowHelpers.h"
18981898
"../../../../../modules/juce_gui_basics/detail/juce_ButtonAccessibilityHandler.h"
18991899
"../../../../../modules/juce_gui_basics/detail/juce_ComponentHelpers.h"
1900+
"../../../../../modules/juce_gui_basics/detail/juce_ComponentPeerHelpers.cpp"
1901+
"../../../../../modules/juce_gui_basics/detail/juce_ComponentPeerHelpers.h"
19001902
"../../../../../modules/juce_gui_basics/detail/juce_CustomMouseCursorInfo.h"
19011903
"../../../../../modules/juce_gui_basics/detail/juce_FocusHelpers.h"
19021904
"../../../../../modules/juce_gui_basics/detail/juce_FocusRestorer.h"
@@ -4163,6 +4165,8 @@ set_source_files_properties(
41634165
"../../../../../modules/juce_gui_basics/detail/juce_AlertWindowHelpers.h"
41644166
"../../../../../modules/juce_gui_basics/detail/juce_ButtonAccessibilityHandler.h"
41654167
"../../../../../modules/juce_gui_basics/detail/juce_ComponentHelpers.h"
4168+
"../../../../../modules/juce_gui_basics/detail/juce_ComponentPeerHelpers.cpp"
4169+
"../../../../../modules/juce_gui_basics/detail/juce_ComponentPeerHelpers.h"
41664170
"../../../../../modules/juce_gui_basics/detail/juce_CustomMouseCursorInfo.h"
41674171
"../../../../../modules/juce_gui_basics/detail/juce_FocusHelpers.h"
41684172
"../../../../../modules/juce_gui_basics/detail/juce_FocusRestorer.h"

‎extras/AudioPerformanceTest/Builds/VisualStudio2022/AudioPerformanceTest_App.vcxproj‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2298,6 +2298,9 @@
22982298
<ClCompile Include="..\..\..\..\modules\juce_gui_basics\detail\juce_AccessibilityHelpers.cpp">
22992299
<ExcludedFromBuild>true</ExcludedFromBuild>
23002300
</ClCompile>
2301+
<ClCompile Include="..\..\..\..\modules\juce_gui_basics\detail\juce_ComponentPeerHelpers.cpp">
2302+
<ExcludedFromBuild>true</ExcludedFromBuild>
2303+
</ClCompile>
23012304
<ClCompile Include="..\..\..\..\modules\juce_gui_basics\drawables\juce_Drawable.cpp">
23022305
<ExcludedFromBuild>true</ExcludedFromBuild>
23032306
</ClCompile>
@@ -3917,6 +3920,7 @@
39173920
<ClInclude Include="..\..\..\..\modules\juce_gui_basics\detail\juce_AlertWindowHelpers.h"/>
39183921
<ClInclude Include="..\..\..\..\modules\juce_gui_basics\detail\juce_ButtonAccessibilityHandler.h"/>
39193922
<ClInclude Include="..\..\..\..\modules\juce_gui_basics\detail\juce_ComponentHelpers.h"/>
3923+
<ClInclude Include="..\..\..\..\modules\juce_gui_basics\detail\juce_ComponentPeerHelpers.h"/>
39203924
<ClInclude Include="..\..\..\..\modules\juce_gui_basics\detail\juce_CustomMouseCursorInfo.h"/>
39213925
<ClInclude Include="..\..\..\..\modules\juce_gui_basics\detail\juce_FocusHelpers.h"/>
39223926
<ClInclude Include="..\..\..\..\modules\juce_gui_basics\detail\juce_FocusRestorer.h"/>

‎extras/AudioPerformanceTest/Builds/VisualStudio2022/AudioPerformanceTest_App.vcxproj.filters‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2899,6 +2899,9 @@
28992899
<ClCompile Include="..\..\..\..\modules\juce_gui_basics\detail\juce_AccessibilityHelpers.cpp">
29002900
<Filter>JUCE Modules\juce_gui_basics\detail</Filter>
29012901
</ClCompile>
2902+
<ClCompile Include="..\..\..\..\modules\juce_gui_basics\detail\juce_ComponentPeerHelpers.cpp">
2903+
<Filter>JUCE Modules\juce_gui_basics\detail</Filter>
2904+
</ClCompile>
29022905
<ClCompile Include="..\..\..\..\modules\juce_gui_basics\drawables\juce_Drawable.cpp">
29032906
<Filter>JUCE Modules\juce_gui_basics\drawables</Filter>
29042907
</ClCompile>
@@ -6789,6 +6792,9 @@
67896792
<ClInclude Include="..\..\..\..\modules\juce_gui_basics\detail\juce_ComponentHelpers.h">
67906793
<Filter>JUCE Modules\juce_gui_basics\detail</Filter>
67916794
</ClInclude>
6795+
<ClInclude Include="..\..\..\..\modules\juce_gui_basics\detail\juce_ComponentPeerHelpers.h">
6796+
<Filter>JUCE Modules\juce_gui_basics\detail</Filter>
6797+
</ClInclude>
67926798
<ClInclude Include="..\..\..\..\modules\juce_gui_basics\detail\juce_CustomMouseCursorInfo.h">
67936799
<Filter>JUCE Modules\juce_gui_basics\detail</Filter>
67946800
</ClInclude>

‎extras/AudioPluginHost/Builds/Android/app/CMakeLists.txt‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2027,6 +2027,8 @@ add_library( ${BINARY_NAME}
20272027
"../../../../../modules/juce_gui_basics/detail/juce_AlertWindowHelpers.h"
20282028
"../../../../../modules/juce_gui_basics/detail/juce_ButtonAccessibilityHandler.h"
20292029
"../../../../../modules/juce_gui_basics/detail/juce_ComponentHelpers.h"
2030+
"../../../../../modules/juce_gui_basics/detail/juce_ComponentPeerHelpers.cpp"
2031+
"../../../../../modules/juce_gui_basics/detail/juce_ComponentPeerHelpers.h"
20302032
"../../../../../modules/juce_gui_basics/detail/juce_CustomMouseCursorInfo.h"
20312033
"../../../../../modules/juce_gui_basics/detail/juce_FocusHelpers.h"
20322034
"../../../../../modules/juce_gui_basics/detail/juce_FocusRestorer.h"
@@ -4446,6 +4448,8 @@ set_source_files_properties(
44464448
"../../../../../modules/juce_gui_basics/detail/juce_AlertWindowHelpers.h"
44474449
"../../../../../modules/juce_gui_basics/detail/juce_ButtonAccessibilityHandler.h"
44484450
"../../../../../modules/juce_gui_basics/detail/juce_ComponentHelpers.h"
4451+
"../../../../../modules/juce_gui_basics/detail/juce_ComponentPeerHelpers.cpp"
4452+
"../../../../../modules/juce_gui_basics/detail/juce_ComponentPeerHelpers.h"
44494453
"../../../../../modules/juce_gui_basics/detail/juce_CustomMouseCursorInfo.h"
44504454
"../../../../../modules/juce_gui_basics/detail/juce_FocusHelpers.h"
44514455
"../../../../../modules/juce_gui_basics/detail/juce_FocusRestorer.h"

‎extras/AudioPluginHost/Builds/VisualStudio2019/AudioPluginHost_App.vcxproj‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2432,6 +2432,9 @@
24322432
<ClCompile Include="..\..\..\..\modules\juce_gui_basics\detail\juce_AccessibilityHelpers.cpp">
24332433
<ExcludedFromBuild>true</ExcludedFromBuild>
24342434
</ClCompile>
2435+
<ClCompile Include="..\..\..\..\modules\juce_gui_basics\detail\juce_ComponentPeerHelpers.cpp">
2436+
<ExcludedFromBuild>true</ExcludedFromBuild>
2437+
</ClCompile>
24352438
<ClCompile Include="..\..\..\..\modules\juce_gui_basics\drawables\juce_Drawable.cpp">
24362439
<ExcludedFromBuild>true</ExcludedFromBuild>
24372440
</ClCompile>
@@ -4150,6 +4153,7 @@
41504153
<ClInclude Include="..\..\..\..\modules\juce_gui_basics\detail\juce_AlertWindowHelpers.h"/>
41514154
<ClInclude Include="..\..\..\..\modules\juce_gui_basics\detail\juce_ButtonAccessibilityHandler.h"/>
41524155
<ClInclude Include="..\..\..\..\modules\juce_gui_basics\detail\juce_ComponentHelpers.h"/>
4156+
<ClInclude Include="..\..\..\..\modules\juce_gui_basics\detail\juce_ComponentPeerHelpers.h"/>
41534157
<ClInclude Include="..\..\..\..\modules\juce_gui_basics\detail\juce_CustomMouseCursorInfo.h"/>
41544158
<ClInclude Include="..\..\..\..\modules\juce_gui_basics\detail\juce_FocusHelpers.h"/>
41554159
<ClInclude Include="..\..\..\..\modules\juce_gui_basics\detail\juce_FocusRestorer.h"/>

0 commit comments

Comments
 (0)