Android: Avoid restarting activities on system-wide theme change

Author: reuk

examples/DemoRunner/Builds/Android/app/src/main/AndroidManifest.xml

@@ -23,7 +23,7 @@
   <uses-feature android:glEsVersion="0x00030000" android:required="true"/>
   <application android:label="@string/app_name" android:name="com.rmsl.juce.JuceApp" android:icon="@drawable/icon" android:hardwareAccelerated="false">
     <receiver android:name="com.rmsl.juce.Receiver" android:exported="false"/>
-    <activity android:name="com.rmsl.juce.JuceActivity" android:configChanges="keyboard|keyboardHidden|orientation|screenSize|navigation|smallestScreenSize|screenLayout"
+    <activity android:name="com.rmsl.juce.JuceActivity" android:configChanges="keyboard|keyboardHidden|orientation|screenSize|navigation|smallestScreenSize|screenLayout|uiMode"
               android:launchMode="singleTask" android:hardwareAccelerated="true" android:exported="true">
       <intent-filter>
         <action android:name="android.intent.action.MAIN"/>

extras/AudioPerformanceTest/Builds/Android/app/src/main/AndroidManifest.xml

@@ -13,7 +13,7 @@
   <uses-permission android:name="android.permission.INTERNET"/>
   <application android:label="@string/app_name" android:name="com.rmsl.juce.JuceApp" android:hardwareAccelerated="false">
     <receiver android:name="com.rmsl.juce.Receiver" android:exported="false"/>
-    <activity android:name="com.rmsl.juce.JuceActivity" android:configChanges="keyboard|keyboardHidden|orientation|screenSize|navigation|smallestScreenSize|screenLayout"
+    <activity android:name="com.rmsl.juce.JuceActivity" android:configChanges="keyboard|keyboardHidden|orientation|screenSize|navigation|smallestScreenSize|screenLayout|uiMode"
               android:launchMode="singleTask" android:hardwareAccelerated="true" android:exported="true">
       <intent-filter>
         <action android:name="android.intent.action.MAIN"/>

extras/AudioPluginHost/Builds/Android/app/src/main/AndroidManifest.xml

@@ -22,7 +22,7 @@
   <uses-feature android:glEsVersion="0x00030000" android:required="true"/>
   <application android:label="@string/app_name" android:name="com.rmsl.juce.JuceApp" android:icon="@drawable/icon" android:hardwareAccelerated="false">
     <receiver android:name="com.rmsl.juce.Receiver" android:exported="false"/>
-    <activity android:name="com.rmsl.juce.JuceActivity" android:configChanges="keyboard|keyboardHidden|orientation|screenSize|navigation|smallestScreenSize|screenLayout"
+    <activity android:name="com.rmsl.juce.JuceActivity" android:configChanges="keyboard|keyboardHidden|orientation|screenSize|navigation|smallestScreenSize|screenLayout|uiMode"
               android:launchMode="singleTask" android:hardwareAccelerated="true" android:exported="true">
       <intent-filter>
         <action android:name="android.intent.action.MAIN"/>

extras/NetworkGraphicsDemo/Builds/Android/app/src/main/AndroidManifest.xml

@@ -14,7 +14,7 @@
   <uses-feature android:glEsVersion="0x00030000" android:required="true"/>
   <application android:label="@string/app_name" android:name="com.rmsl.juce.JuceApp" android:icon="@drawable/icon" android:hardwareAccelerated="false">
     <receiver android:name="com.rmsl.juce.Receiver" android:exported="false"/>
-    <activity android:name="com.rmsl.juce.JuceActivity" android:configChanges="keyboard|keyboardHidden|orientation|screenSize|navigation|smallestScreenSize|screenLayout"
+    <activity android:name="com.rmsl.juce.JuceActivity" android:configChanges="keyboard|keyboardHidden|orientation|screenSize|navigation|smallestScreenSize|screenLayout|uiMode"
               android:launchMode="singleTask" android:hardwareAccelerated="true" android:exported="true">
       <intent-filter>
         <action android:name="android.intent.action.MAIN"/>

extras/Projucer/Source/ProjectSaving/jucer_ProjectExport_Android.h

@@ -1846,7 +1846,7 @@ class AndroidProjectExporter final : public ProjectExporter
         setAttributeIfNotPresent (*act, "android:name", getActivityClassString());
 
         if (! act->hasAttribute ("android:configChanges"))
-            act->setAttribute ("android:configChanges", "keyboard|keyboardHidden|orientation|screenSize|navigation|smallestScreenSize|screenLayout");
+            act->setAttribute ("android:configChanges", "keyboard|keyboardHidden|orientation|screenSize|navigation|smallestScreenSize|screenLayout|uiMode");
 
         if (androidScreenOrientation.get() != "unspecified")
         {

modules/juce_gui_basics/native/juce_Windowing_android.cpp

@@ -2562,18 +2562,25 @@ class Desktop::NativeDarkModeChangeDetectorImpl  : private ActivityLifecycleCall
 
     bool isDarkModeEnabled() const noexcept  { return darkModeEnabled; }
 
-    void onActivityStarted (jobject /*activity*/) override
+private:
+    void onActivityStarted (jobject) override
     {
-        const auto isEnabled = getDarkModeSetting();
+        updateMode();
+    }
 
-        if (darkModeEnabled != isEnabled)
-        {
-            darkModeEnabled = isEnabled;
+    void onActivityConfigurationChanged (jobject) override
+    {
+        updateMode();
+    }
+
+    void updateMode()
+    {
+        const auto current = getDarkModeSetting();
+
+        if (std::exchange (darkModeEnabled, current) != current)
             Desktop::getInstance().darkModeChanged();
-        }
     }
 
-private:
     static bool getDarkModeSetting()
     {
         auto* env = getEnv();