SessionPerRequestLauncher does not check its preconditions

[mpkorstanje]

I was able to produce the following stacktrace through IDEA-384245. While this is caused by incorrect use of the API by InteliJ IDEA, the pre-condition isn't checked at the public API boundary.

I.e. SessionPerRequestLauncher.execute should have thrown this exception, making the stack-trace much shorter.

Internal Error occurred.
org.junit.platform.commons.PreconditionViolationException: LauncherDiscoveryRequest must not be null
	at org.junit.platform.commons.util.Preconditions.condition(Preconditions.java:323)
	at org.junit.platform.commons.util.Preconditions.notNull(Preconditions.java:57)
	at org.junit.platform.launcher.core.LauncherExecutionRequestBuilder.request(LauncherExecutionRequestBuilder.java:72)
	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:90)
	at org.junit.platform.launcher.core.DelegatingLauncher.execute(DelegatingLauncher.java:48)
	at org.junit.platform.launcher.core.InterceptingLauncher.lambda$execute$0(InterceptingLauncher.java:41)
	at org.junit.platform.launcher.core.ClasspathAlignmentCheckingLauncherInterceptor.intercept(ClasspathAlignmentCheckingLauncherInterceptor.java:25)
	at org.junit.platform.launcher.core.InterceptingLauncher.execute(InterceptingLauncher.java:40)
	at org.junit.platform.launcher.core.DelegatingLauncher.execute(DelegatingLauncher.java:48)
	at org.junit.platform.launcher.core.SessionPerRequestLauncher.execute(SessionPerRequestLauncher.java:67)
	at com.intellij.junit6.JUnit6IdeaTestRunner.startRunnerWithArgs(JUnit6IdeaTestRunner.java:67)
	at com.intellij.rt.junit.IdeaTestRunner$Repeater$1.execute(IdeaTestRunner.java:38)
	at com.intellij.rt.execution.junit.TestsRepeater.repeat(TestsRepeater.java:11)
	at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:35)
	at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:237)
	at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:58)

Deliverables

• Check the preconditions of SessionPerRequestLauncher
• Check the preconditions of other Launcher implementations

[mehulimukherjee]

Hi @marcphilipp,
If no one is working on this at the moment, could you please assign this to me?
Thanks,
Mehuli

[marcphilipp]

@mehulimukherjee Thanks for volunteering! The issue is now assigned to you.

[mehulimukherjee]

Thank you @marcphilipp