Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential error #110

Open
Fernadoo opened this issue Jun 27, 2020 · 1 comment
Open

Potential error #110

Fernadoo opened this issue Jun 27, 2020 · 1 comment

Comments

@Fernadoo
Copy link

In game.py, line 62-72:

def current_state(self):
    ....
    square_state[0][move_curr // self.width, move_curr % self.height] = 1.0
    ....

I assume you may actually mean [move_curr // self.width, move_curr % self.width].
Not a fatal bug if you are testing with square boards.

@WangChuanYuan
Copy link

It should be [move_curr // self.height, move_curr % self.height]? As the shape of square_state is (4, self.width, self.height), so the third dimension should be height?
By the way, why reshape to (height, width) in

mcts_porb.reshape(self.board_height, self.board_width)), i)
,
although they are the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants