Button role renders as plain link when wrapped in a div

[mfisher87]

Description

Version 1.5.0

<div>

{button}`my button <https://example.com>`

</div>

Renders as a plain link (<a> tag without "button" class). But remove the wrapping div and it renders correctly (<a> tag with "button" class).

Proposed solution

Add a button directive which allows me to pass style information to the button similar to a figure directive.

And/or, include the "button" class whenever rendering the button role.

Additional notes

I'm trying to wrap the button because I want to center-align my button.

[choldgraf]

Can confirm! Here's an example in the sandbox.

[mfisher87]

I hoped I could work around this by writing plain HTML. But the HTML gets modified, stripping style information and other properties, before it's rendered.

https://github.com/geojupyter/events.geojupyter.org/pull/9/files

<a class="button" style="display: block; margin: 0 auto; text-align: center" href="https://agu.confex.com/agu/agu25/prelim.cgi/Session/252486" target="_blank" rel="noreferrer">
  Submit an abstract to speak or present a poster
</a>

I want this button to be a full-width call-to-action button. In the sandbox, the AST looks great!

type: root
children:
  - type: html
    value: >-
      <a class="button" style="display: block; margin: 0 auto; text-align:
      center" href="https://agu.confex.com/agu/agu25/prelim.cgi/Session/252486"
      target="_blank" rel="noreferrer">
        Submit an abstract to speak or present a poster
      </a>

But it renders as:

<a target="_blank" rel="noreferrer" href="https://agu.confex.com/agu/agu25/prelim.cgi/Session/252486" class="button">Submit an abstract to speak or present a poster</a>

This feels like a separate issue, will search to see if there's an open one already.

[choldgraf]

Just a quick note: there are two AST previews in the sandbox. One for pre-transformations, and one for post-transformations (POST). That's the difference in your outcomes:

[mfisher87]

The post-transform AST still looks "good" to me (as someone who knows nothing about what to expect 😉) -- the style information is there! It seems to only get stripped out when the AST is rendered to HTML.

Do you think this is a separate bug? Or intended behavior?

[choldgraf]

Oh interesting - in that idea I have no idea what's going on! Maybe it's a theme thing?