-
Notifications
You must be signed in to change notification settings - Fork 398
Open
Labels
Description
I'm having problems when using testing/local-binder-k8s-hub/binderhub_config.py
because of
binderhub/testing/local-binder-k8s-hub/binderhub_config.py
Lines 22 to 25 in b39a9d7
try: | |
jupyterhub_ip = subprocess.check_output(["minikube", "ip"], text=True).strip() | |
except (subprocess.SubprocessError, FileNotFoundError): | |
jupyterhub_ip = "192.168.1.100" |
I want to change the code to use a user defined environment variable, for example LOCAL_BINDER_JUPYTERHUB_IP
. If the user defines the variable, we use the IP address or domain provided by the user. If no LOCAL_BINDER_JUPYTERHUB_IP
is provided, we show a warning and continue with localhost
.
The documentation will be updated to reflect the change. Users of minikube
can run
LOCAL_BINDER_JUPYTERHUB_IP=$(minikube ip) python3 -m binderhub -f testing/local-binder-k8s-hub/binderhub_config.py