Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement prometheus metrics #300

Open
minrk opened this issue Mar 8, 2021 · 1 comment
Open

Implement prometheus metrics #300

minrk opened this issue Mar 8, 2021 · 1 comment

Comments

@minrk
Copy link
Member

minrk commented Mar 8, 2021

Proposed change

Drop deprecated statsd metrics in favor of prometheus, which we use everywhere. We don't use statsd anywhere anymore.

Alternative options

Continue not having prometheus metrics and/or don't drop statsd

Who would use this feature?

JupyterHub (or other) deployments that use prometheus, e.g. mybinder.org.

(Optional): Suggest a solution

  • Add prometheus as a dependency
  • Add metrics API endpoint
  • Replace all existing statsd metrics with prometheus
  • Add additional metrics, if any feel necessary (?)
  • Remove statsd as a dependency
  • CLI option to opt-in to (or -out of) metrics
@welcome
Copy link

welcome bot commented Mar 8, 2021

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant