Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to commander 9 #384

Open
guimard opened this issue Mar 29, 2022 · 3 comments
Open

Update to commander 9 #384

guimard opened this issue Mar 29, 2022 · 3 comments

Comments

@guimard
Copy link

guimard commented Mar 29, 2022

Hi,

for the record, here is a patch for commander 9 (used to publish configurable-http-proxy in Debian):

--- a/bin/configurable-http-proxy
+++ b/bin/configurable-http-proxy
@@ -114,6 +114,7 @@
     process.exit(1);
   }
   previous[headerParts[0]] = headerParts[1];
+  return previous;
 }

 cli.parse(process.argv);

Cheers,
Yadd

@guimard guimard added the bug label Mar 29, 2022
@welcome
Copy link

welcome bot commented Mar 29, 2022

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@consideRatio
Copy link
Member

Thank you @guimard! The change suggestion seems resolved and part of #369, but we still use an old version of commander, but I want to cut a release dropping support for node 10 and bumping commander to a modern version that no longer supports node 10.

@consideRatio
Copy link
Member

This is described about commander 8.x.y

The current version of Commander is fully supported on Long Term Support versions of node, and requires at least node v12.

Version 9.x.y clarifies and sais node v12.20.0+ is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants