Add Option to Clear Notebook Outputs Before Commit #1434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
krassowski
reviewed
Nov 27, 2025
krassowski
reviewed
Nov 27, 2025
Meriem-BenIsmail
force-pushed
the
clean-outputs
branch
from
64fd7a0 to
826b73b
Compare
Meriem-BenIsmail
force-pushed
the
clean-outputs
branch
from
826b73b to
32411ae
Compare
krassowski
reviewed
Nov 28, 2025
Meriem-BenIsmail
force-pushed
the
clean-outputs
branch
from
ec60839 to
e5370b7
Compare
Member
|
Should we merge this? @Meriem-BenIsmail |
Member
Author
Yes no problem on my end. |
jtpio
reviewed
Jan 7, 2026
| full_cmd = cmd + options + [full_path] | ||
|
|
||
| # Run the cleaning command | ||
| subprocess.run(full_cmd, check=True) |
Member
There was a problem hiding this comment.
Should this be using the existing self.__execute() instead of the blocking subprocess.run()?
jtpio
reviewed
Jan 7, 2026
| return {"code": code, "message": output.strip()} | ||
|
|
||
| async def check_notebooks_with_outputs(self, path): | ||
| import nbformat, os |
Member
There was a problem hiding this comment.
These imports already seem to be listed at the top of the file?
Member
Author
There was a problem hiding this comment.
yes thanks for noticing.
jtpio
reviewed
Jan 7, 2026
| const result = await dialog.launch(); | ||
| dialog.dispose(); | ||
|
|
||
| if (result.button.label === this.props.trans.__('Cancel')) { |
Member
There was a problem hiding this comment.
Can we use result.button.accept here for the check?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #392.
This PR introduces an optional workflow to help users keep cleaner Git histories when working with Jupyter notebooks.
When committing, if staged notebooks contain cell outputs, a dialog now appears offering two choices:
Screencast.from.2025-11-27.09-39-48.webm
A new configuration option has been added to the Git extension settings:
When enabled, notebook outputs are automatically stripped before every commit, skipping the dialog entirely.
Implementation Details
Backend endpoints were added to:
nbconvert.